Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maintainability] Cycles found in extension's code #207

Open
marcdumais-work opened this issue Feb 20, 2024 · 1 comment
Open

[maintainability] Cycles found in extension's code #207

marcdumais-work opened this issue Feb 20, 2024 · 1 comment
Labels
tech debt Somethings to fix technical debt

Comments

@marcdumais-work
Copy link
Contributor

marcdumais-work commented Feb 20, 2024

After updating to a more recent version of Eslint, the linter started to report an issue with ProgressMessages in vscode-trace-extension/src/trace-explorer/trace-tree.ts having already been defined. After scratching my head for a while, I thought it could be a "cycle" issue. That turned-out to apparently be correct: see yellow lines in this graph, generated using "dependency-cruiser" [1]. The worst of it seems centered around extension.ts

Dependency graph (look at the yellow lines):

dependency-graph-only-extension

For info about the configuration I used and how to run dependency-cruiser, see this commit on my fork

@marcdumais-work marcdumais-work added the tech debt Somethings to fix technical debt label Feb 20, 2024
@marcdumais-work
Copy link
Contributor Author

Text version of the "internal circular dependencies":

  warn no-circular: vscode-trace-extension/src/trace-explorer/trace-tree.ts → 
      vscode-trace-extension/src/trace-viewer-panel/trace-viewer-webview-panel.ts
      →
      vscode-trace-extension/src/extension.ts →
      vscode-trace-extension/src/trace-explorer/trace-tree.ts
  warn no-circular: vscode-trace-extension/src/trace-explorer/trace-tree.ts → 
      vscode-trace-extension/src/trace-explorer/analysis-tree.ts →
      vscode-trace-extension/src/trace-viewer-panel/trace-viewer-webview-panel.ts
      →
      vscode-trace-extension/src/extension.ts →
      vscode-trace-extension/src/trace-explorer/trace-tree.ts
  warn no-circular: vscode-trace-extension/src/trace-explorer/opened-traces/trace-explorer-opened-traces-webview-provider.ts → 
      vscode-trace-extension/src/trace-viewer-panel/trace-viewer-webview-panel.ts
      →
      vscode-trace-extension/src/extension.ts →
      vscode-trace-extension/src/trace-explorer/opened-traces/trace-explorer-opened-traces-webview-provider.ts
  warn no-circular: vscode-trace-extension/src/trace-explorer/available-views/trace-explorer-available-views-webview-provider.ts → 
      vscode-trace-extension/src/trace-viewer-panel/trace-viewer-webview-panel.ts
      →
      vscode-trace-extension/src/extension.ts →
      vscode-trace-extension/src/trace-explorer/available-views/trace-explorer-available-views-webview-provider.ts
  warn no-circular: vscode-trace-extension/src/external-api/external-api.ts → 
      vscode-trace-extension/src/trace-viewer-panel/trace-viewer-webview-panel.ts
      →
      vscode-trace-extension/src/extension.ts →
      vscode-trace-extension/src/external-api/external-api.ts
  warn no-circular: vscode-trace-extension/src/extension.ts → 
      vscode-trace-extension/src/trace-viewer-panel/trace-viewer-webview-panel.ts
      →
      vscode-trace-extension/src/extension.ts
  warn no-circular: vscode-trace-extension/src/extension.ts → 
      vscode-trace-extension/src/trace-explorer/trace-tree.ts →
      vscode-trace-extension/src/extension.ts
  warn no-circular: vscode-trace-extension/src/extension.ts → 
      vscode-trace-extension/src/trace-explorer/properties/trace-explorer-properties-view-webview-provider.ts
      →
      vscode-trace-extension/src/extension.ts
  warn no-circular: vscode-trace-extension/src/extension.ts → 
      vscode-trace-extension/src/trace-explorer/opened-traces/trace-explorer-opened-traces-webview-provider.ts
      →
      vscode-trace-extension/src/extension.ts
  warn no-circular: vscode-trace-extension/src/extension.ts → 
      vscode-trace-extension/src/trace-explorer/available-views/trace-explorer-available-views-webview-provider.ts
      →
      vscode-trace-extension/src/extension.ts
  warn no-circular: vscode-trace-extension/src/extension.ts → 
      vscode-trace-extension/src/trace-explorer/analysis-tree.ts →
      vscode-trace-extension/src/trace-viewer-panel/trace-viewer-webview-panel.ts
      →
      vscode-trace-extension/src/extension.ts
  warn no-circular: vscode-trace-extension/src/extension.ts → 
      vscode-trace-extension/src/external-api/external-api.ts →
      vscode-trace-extension/src/extension.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Somethings to fix technical debt
Projects
None yet
Development

No branches or pull requests

1 participant