-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maintainability] Cycles found in extension's code #207
Labels
tech debt
Somethings to fix technical debt
Comments
Text version of the "internal circular dependencies":
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After updating to a more recent version of
Eslint
, the linter started to report an issue withProgressMessages
invscode-trace-extension/src/trace-explorer/trace-tree.ts
having already been defined. After scratching my head for a while, I thought it could be a "cycle" issue. That turned-out to apparently be correct: see yellow lines in this graph, generated using "dependency-cruiser" [1]. The worst of it seems centered aroundextension.ts
Dependency graph (look at the yellow lines):
For info about the configuration I used and how to run
dependency-cruiser
, see this commit on my forkThe text was updated successfully, but these errors were encountered: