Error loading workflow model file in VS Code extension

[gee4vee]

We are using the example workflow node server and are working on making this example run as a VS Code extension just like the task list example. We have made a workflow client following the task list project template by copying the tasklist-glsp and tasklist-vscode sources and modifying them appropriately to load a workflow web view.

We started the server and the client successfully but when we try to open example1.wf we get this error in the server.

/Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-server-node/node_modules/.bin/ts-node ./glsp-server-node/src/index.ts
Debugger attached.
11:16:17 AM info -  [SocketServerLauncher] The GLSP server is ready to accept new client requests on port: 5007
[GLSP-Server]:Startup completed
/Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-server-node/node_modules/@eclipse-glsp/server-node/src/di/diagram-module.ts:314
        binding.add(ModelSourceChangedAction.KIND);
                                             ^
TypeError: Cannot read properties of undefined (reading 'KIND')
    at WorkflowDiagramModule.configureClientActions (/Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-server-node/node_modules/@eclipse-glsp/server-node/src/di/diagram-module.ts:314:46)
    at /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-server-node/node_modules/@eclipse-glsp/server-node/src/di/diagram-module.ts:183:105
    at WorkflowDiagramModule.configureMultiBinding (/Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-server-node/node_modules/@eclipse-glsp/server-node/src/di/glsp-module.ts:63:9)
    at WorkflowDiagramModule.configure (/Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-server-node/node_modules/@eclipse-glsp/server-node/src/di/diagram-module.ts:183:14)
    at WorkflowDiagramModule.registry (/Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-server-node/node_modules/@eclipse-glsp/server-node/src/di/glsp-module.ts:42:18)
    at Container.load (/Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-server-node/node_modules/inversify/src/container/container.ts:110:27)
    at DefaultGlobalActionProvider.createDiagramContainer (/Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-server-node/node_modules/@eclipse-glsp/server-node/src/actions/global-action-provider.ts:52:19)
    at /Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-server-node/node_modules/@eclipse-glsp/server-node/src/actions/global-action-provider.ts:41:36
    at Map.forEach (<anonymous>)
    at new DefaultGlobalActionProvider (/Users/gvalenc/git/DevX/solution-builder-glsp-workflow/glsp-server-node/node_modules/@eclipse-glsp/server-node/src/actions/global-action-provider.ts:40:24)
Waiting for the debugger to disconnect...

Since there isn't a working workflow example with a node server, can we get some help to get this to work? We cannot use the Java server.

[gee4vee]

Looking into the stack trace, ModelSourceChangedAction does not exist in the latest version of protocol. It was renamed to SourceModelChangedAction.

[planger]

Yes, this has been recently renamed to SourceModelChangedAction to be in line with the terminology of a source model and the graphical model (see also a16967e). Model source was an old term that we've used but it overlaps with a concept from sprotty. So we renamed it.

[gee4vee]

@planger Is this going to be fixed in @eclipse-glsp/server-node? That is where it is trying to use ModelSourceChangedAction.

[planger]

Yes, there already is an open PR for it, but it hasn't been merged yet.
Since it now has been approved and went through the CI, I'll merge it now.

[gee4vee]

Thank you! When does the new NPM version usually arrive?

[planger]

Just landed: https://www.npmjs.com/package/@eclipse-glsp/server-node/v/0.9.0-next.b178eb2.24

[planger]

Since there isn't a working workflow example with a node server, can we get some help to get this to work? We cannot use the Java server.

There is an example for the workflow diagram server based on the node server framework here: https://github.com/eclipse-glsp/glsp-server-node/tree/main/examples/workflow-server

[gee4vee]

Yes, I mentioned that one. We are using it. But there is no VS code integration client for workflow. That is what we are trying to build.

[planger]

Ah ok, I'm sorry, I was a bit confused :-)

[gee4vee]

The latest version of server-node fixes this. Thank you!

[planger]

That's great! 🚀

Btw, if you are (planning to) use GLSP, we'd be very happy if you or your organization would be listed as a contributor/adopter at https://ecdtools.eclipse.org/adopters and you'd give us a star on Github. It is very easy to get listed, basically it is just opening an issue here with your logo. Thanks for considering!