-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCANOSS does not work in built Theia IDE #14648
Comments
See also #14643 (comment) |
I'm not sure why an update to 3.0 would fix the problem, though: is the new mechanism for checking the class name more robust against name mangling, @sdirix ? |
scanoss depends on node-fetch <3. node-fetch in that version fails their instance checks, as it relies on constructor/class names which are removed by the backend bundling. Adjusts the generated webpack configuration to keep the class name for AbortSignal as this is the name checked in node-fetch. fixes: eclipse-theia#14648
scanoss depends on node-fetch <3. node-fetch in that version fails their instance checks, as it relies on constructor/class names which are removed by the backend bundling. Adjusts the generated webpack configuration to keep the class name for AbortSignal as this is the name checked in node-fetch. fixes eclipse-theia#14648
@tsmaeder Yes, However fixing this issue via resolutions has some downsides:
Therefore I suggest to adjust the webpack generator slightly, see #14650 To get rid of this workaround later we need to either
Note that the |
Note that to fix the Theia IDE we also need PR eclipse-theia/theia-ide#434 as we already override the |
@sdirix I tried your fix, but it didn't work for me (see comment in the PR). To double-check, I tried to use the feature when doing a normal (development) build from master. But that does not work either form me. When I click on the "ScanOSS" button in the browser version, I get
in the browser log. |
Never saw this error. I will try to reproduce this on a Windows machine |
Same error in Electron. |
Maybe related, I get these errors when I type into the AI chat:
|
I was able to reproduce the error in Windows. I'll investigate.
I don't think this is related. This seemingly comes in via a VS Code extension as I don't see this error when running Theia without plugins. |
On Windows, the scanoss library returns its results in a different shape than on the other platforms. We now anticipate this behavior. fixes eclipse-theia#14648
scanoss depends on node-fetch <3. node-fetch in that version fails their instance checks, as it relies on constructor/class names which are removed by the backend bundling. Adjusts the generated webpack configuration to keep the class name for AbortSignal as this is the name checked in node-fetch. fixes #14648
On Windows, the scanoss library returns its results in a different shape than on the other platforms. We now anticipate this behavior. fixes #14648
scanoss depends on node-fetch <3. node-fetch in that version fails their instance checks, as it relies on constructor/class names which are removed by the backend bundling. Adjusts the generated webpack configuration to keep the class name for AbortSignal as this is the name checked in node-fetch. fixes #14648
The Windows issue was fixed here: #14653 |
result:
for details, see: #14643 (comment)
The text was updated successfully, but these errors were encountered: