Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve some /heartbeat traces in edxapp DD telemetry #890

Closed
timmc-edx opened this issue Jan 10, 2025 · 4 comments
Closed

Preserve some /heartbeat traces in edxapp DD telemetry #890

timmc-edx opened this issue Jan 10, 2025 · 4 comments

Comments

@timmc-edx
Copy link
Member

No description provided.

@timmc-edx timmc-edx converted this from a draft issue Jan 10, 2025
@timmc-edx timmc-edx moved this from Ready For Development to Backlog in Arch-BOM Jan 10, 2025
@timmc-edx timmc-edx removed the status in Arch-BOM Jan 10, 2025
@robrap
Copy link
Contributor

robrap commented Jan 10, 2025

We may need a different percent of retention for LMS than other services. It should be very quick to just add a new retention rule that is edxapp (or LMS) specific, and tune it until we've got enough that are useful and not annoying.

They should all be appearing in the Live View, right? But I guess they wouldn't be recording traces.

@timmc-edx
Copy link
Member Author

Oh... we actually are getting spans indexed for these: env:prod service:edx-edxapp-lms resource_name:"GET openedx.core.djangoapps.heartbeat.views.heartbeat" -- not sure why I wasn't seeing these before. I think I was using the wrong query, a URL-based one.

So maybe we can close this out? I think there was some other healthcheck-related thing we wanted to keep a small percentage of (access logs?) but I'm not sure.

@robrap
Copy link
Contributor

robrap commented Jan 10, 2025

I think we are excluding 99.9%, so we only have 0.1%. But, there should be some if we need them.

@timmc-edx
Copy link
Member Author

Turns out the logs are present, but tagged service:edx-nginx. Filed #893 for that, and closing this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants