Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop - use new fork #6187

Closed
Tracked by #6182
Xhale1 opened this issue Aug 28, 2022 · 6 comments
Closed
Tracked by #6182

Drag and drop - use new fork #6187

Xhale1 opened this issue Aug 28, 2022 · 6 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@Xhale1
Copy link

Xhale1 commented Aug 28, 2022

Hello!

react-beautiful-dnd is no longer being maintained by Atlassian per their readme. It currently doesn't support React 18 and strict mode.

Another developer and myself created a fork @hello-pangea/dnd which improves a few things:

  • React 18 support
  • React strict mode support
  • React redux 8 support
  • Converted entire codebase and tests to typescript
  • Run test suite with React 16, 17, and 18

@hello-pangea/dnd is a drop-in replacement for react-beautiful-dnd and should require no changes to support aside from renamed imports.

Would Elastic be open to a PR migrating to @hello-pangea/dnd?

@thompsongl
Copy link
Contributor

Thanks for the note, @Xhale1. I hadn't seen that RBD had gone into maintenance mode.
We'll need to evaluate the correct direction for EUI in conjunction with an upgrade to React 18.

I'll add this to our meta issue tracking required changes: #6182

@Xhale1
Copy link
Author

Xhale1 commented Aug 29, 2022

@thompsongl sounds good. We've received some very positive feedback about migrating to the new fork so I don't anticipate it will be a significant engineering challenge. Naturally there's more than engineering to consider.

Let me know if there's anything myself or other maintainers can help with 👍

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

github-actions bot commented Mar 5, 2023

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

@cee-chen
Copy link
Contributor

cee-chen commented Mar 6, 2023

Re-opening as still valid / related to React 18

@cee-chen
Copy link
Contributor

cee-chen commented Jul 3, 2023

This upgrade has happened as part of our React 18 feature branch (which is still not yet available in main / as a release, but will be once the feature branch is deemed ready to go - hopefully in the next month or so here). See #6868

Thanks so much again @Xhale1 for your amazing work with the fork! The upgrade was flawless and cleaned up a bunch of our tests. ❤️ Y'all are amazing!

@cee-chen cee-chen closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

4 participants