Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Use new AxisLabelOrientationSelector component in XY chart toolbar #206040

Open
mariairiartef opened this issue Jan 9, 2025 · 1 comment · May be fixed by #208002
Open

[Lens] Use new AxisLabelOrientationSelector component in XY chart toolbar #206040

mariairiartef opened this issue Jan 9, 2025 · 1 comment · May be fixed by #208002
Assignees
@mariairiartef
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@mariairiartef
Copy link
Contributor

mariairiartef commented Jan 9, 2025 •
edited
Loading

Describe the refactor

In PR #202143 we created the AxisLabelOrientationSelector component to enable changing the label rotation.

Image

This component was extracted from x-pack/platform/plugins/shared/lens/public/visualizations/xy/xy_config_panel/axis_settings_popover.tsx. We need to replace the existing code in the above mentioned file with the new AxisLabelOrientationSelector component to avoid duplication.

Additionally, we need to extract the AxesSettingsConfigKeys type in other file so we can reuse it in x-pack/platform/plugins/shared/lens/public/shared_components/axis/ticks/axis_ticks_settings.tsx to avoid importing from XY types.
@mariairiartef mariairiartef added Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture labels Jan 9, 2025
@mariairiartef mariairiartef self-assigned this Jan 9, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mariairiartef mariairiartef mentioned this issue Jan 9, 2025
Merged
3 tasks
@mariairiartef mariairiartef linked a pull request Jan 23, 2025 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariairiartef mariairiartef

Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Use AxisLabelOrientationSelector in xy axis settings mariairiartef/kibana
2 participants
@elasticmachine @mariairiartef