Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrdade from 24.9.1 to v24.13.3+(include 25.1.8) snap publish to github would fail #8768

Open
zxdong262 opened this issue Jan 13, 2025 · 2 comments

Comments

@zxdong262
Copy link

  • Electron-Builder Version: 25.1.8
  • Node Version: 20.x
  • Electron Version: 30.x
  • Electron Type (current, beta, nightly): 30.x stable

not using

  • Target: snap

After upgrdade electron-builder from 24.9.1 to v24.13.3+(also tried 25.1.8 current version, same result), the snap file, publish to github would fail, but publish to snap store would success, no other changes,

cmd

electron-builder --linux snap -p always

the electron-builder.json

{
  "appId": "org.electerm.electerm",
  "directories": {
    "app": "work/app",
    "output": "dist",
    "buildResources": "node_modules/@electerm/electerm-resource/build-res"
  },
  "electronLanguages": ["en-US"],
  "asar": true,
  "artifactName": "${productName}-${version}-${os}-${arch}.${ext}",
  "win": {
    "target": ["tar.gz", "appx", "nsis"],
    "icon": "node_modules/@electerm/electerm-resource/build/icons-win.ico",
    "publish": ["github"]
  },
  "appx": {
    "applicationId": "electerm",
    "identityName": "64159ZHAOXudong.electerm",
    "publisher": "CN=9F481654-170A-434C-8259-984D2EB1FD7F",
    "publisherDisplayName": "ZHAO Xudong"
  },
  "nsis": {
    "oneClick": false,
    "artifactName": "${productName}-${version}-${os}-${arch}-installer.${ext}",
    "allowToChangeInstallationDirectory": true
  },
  "mac": {
    "category": "public.app-category.developer-tools",
    "target": "dmg",
    "icon": "node_modules/@electerm/electerm-resource/build/icons.icns",
    "publish": ["github"],
    "hardenedRuntime": true,
    "gatekeeperAssess": false,
    "entitlements": "./build/entitlements.plist",
    "entitlementsInherit": "./build/entitlements.plist",
    "notarize": {
      "teamId": "__teamId"
    }
  },
  "dmg": {
    "contents": [
      {
        "x": 110,
        "y": 190
      },
      {
        "x": 440,
        "y": 190,
        "type": "link",
        "path": "/Applications"
      }
    ]
  },
  "linux": {
    "category": "Development;System;TerminalEmulator",
    "icon": "node_modules/@electerm/electerm-resource/res/imgs",
    "target": [
      "rpm",
      "deb",
      "tar.gz",
      "snap"
    ],
    "publish": ["github"]
  },
  "snap": {
    "confinement": "classic",
    "publish": ["github"]
  }
}
@mmaietta
Copy link
Collaborator

Can you please provide debug logs with env var DEBUG=electron-builder set?

@zxdong262
Copy link
Author

https://github.com/electerm/electerm/actions/runs/12733681742/job/35490334018

Run node build/bin/build-linux-rpm-snap
  **mnode build/bin/build-linux-rpm-snap
  shell: /usr/bin/bash -e {0}
  env:
    GH_TOKEN: ***
    BUILD_NUMBER: ***
    CUSTOM_UPLOAD_URL: 
running build for linux part [2](https://github.com/electerm/electerm/actions/runs/12733681742/job/35490334018#step:9:2)
build rpm
  • electron-builder  version=25.***.8 os=5.***5.0-***074-azure
  • artifacts will be published if draft release exists  reason=CI detected
  • loaded configuration  file=/home/runner/work/electerm/electerm/electron-builder.json
  • @electron/rebuild already used by electron-builder, please consider to remove excess dependency from devDependencies

To ensure your native dependencies are always matched electron version, simply add script `"postinstall": "electron-builder install-app-deps" to your `package.json`
  • executing @electron/rebuild  electronVersion=[3](https://github.com/electerm/electerm/actions/runs/12733681742/job/35490334018#step:9:3)0.5.*** arch=x64 buildFromSource=false appDir=work/app
  • installing native dependencies  arch=x6[4](https://github.com/electerm/electerm/actions/runs/12733681742/job/35490334018#step:9:4)
  • preparing       moduleName=@serialport/bindings-cpp arch=x64
  • finished        moduleName=@serialport/bindings-cpp arch=x64
  • preparing       moduleName=cpu-features arch=x64
  • finished        moduleName=cpu-features arch=x64
  • preparing       moduleName=node-pty arch=x64
  • finished        moduleName=node-pty arch=x64
  • preparing       moduleName=@serialport/bindings-cpp arch=x64
  • finished        moduleName=@serialport/bindings-cpp arch=x64
  • preparing       moduleName=cpu-features arch=x64
  • finished        moduleName=cpu-features arch=x64
  • preparing       moduleName=node-pty arch=x64
  • finished        moduleName=node-pty arch=x64
  • completed installing native dependencies
  • packaging       platform=linux arch=x64 electron=30.[5](https://github.com/electerm/electerm/actions/runs/12733681742/job/35490334018#step:9:5).*** appOutDir=dist/linux-unpacked
  • downloading     url=https://github.com/electron/electron/releases/download/v30.5.***/electron-v30.5.***-linux-x[6](https://github.com/electerm/electerm/actions/runs/12733681742/job/35490334018#step:9:6)4.zip size=***04 MB parts=8
  • downloaded      url=https://github.com/electron/electron/releases/download/v30.5.***/electron-v30.5.***-linux-x64.zip duration=9[7](https://github.com/electerm/electerm/actions/runs/12733681742/job/35490334018#step:9:7)5ms
  • building        target=rpm arch=x64 file=dist/electerm-***.60.0-linux-x[8](https://github.com/electerm/electerm/actions/runs/12733681742/job/35490334018#step:9:9)6_64.rpm
  • adding autoupdate files for: rpm. (Beta feature)  resourceDir=dist/linux-unpacked/resources
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/fpm-***.[9](https://github.com/electerm/electerm/actions/runs/12733681742/job/35490334018#step:9:10).3-2.3.***-linux-x86_64/fpm-***.9.3-2.3.***-linux-x86_64.7z size=5.0 MB parts=***
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/fpm-***.9.3-2.3.***-linux-x86_64/fpm-***.9.3-2.3.***-linux-x86_64.7z duration=829ms
  • publishing      publisher=Github (owner: electerm, project: electerm, version: ***.60.0)
  • uploading       file=electerm-***.60.0-linux-x86_64.rpm provider=github
  • skipped publishing  file=electerm-***.60.0-linux-x86_64.rpm reason=release doesn't exist and not created because "publish" is not "always" and build is not on tag tag=v***.60.0 version=***.60.0
  • skipped publishing  file=latest-linux.yml reason=release doesn't exist and not created because "publish" is not "always" and build is not on tag tag=v***.60.0 version=***.60.0

build snap
Error: Command failed: /home/runner/work/electerm/electerm/node_modules/.bin/electron-builder --linux snap -p always
[20](https://github.com/electerm/electerm/actions/runs/12733681742/job/35490334018#step:9:21)25-0***-***2T***2:56:56.562Z electron-builder:publish Explicit publish provider: [
  "github"
]
2025-0***-***2T***2:57:***8.6***6Z electron-builder:publish artifactCreated (isPublish: true): {
  "file": "/home/runner/work/electerm/electerm/dist/electerm-***.60.0-linux-amd64.snap",
  "safeArtifactName": null,
  "target": {
    "name": "snap",
    "isAsyncSupported": true,
    "packager": "<stripped sensitive data>",
    "helper": {
      "packager": "<stripped sensitive data>",
      "iconPromise": {
        "_value": {},
        "creator": null
      },
      "mimeTypeFilesPromise": {
        "_value": null
      },
      "maxIconPath": "/home/runner/work/electerm/electerm/node_modules/@electerm/electerm-resource/res/imgs/electerm-round-***28x***28.png"
    },
    "outDir": "/home/runner/work/electerm/electerm/dist",
    "options": {
      "category": "Development;System;TerminalEmulator",
      "icon": "node_modules/@electerm/electerm-resource/res/imgs",
      "target": [
        "rpm",
        "deb",
        "tar.gz",
        "snap"
      ],
      "publish": [
        "github"
      ],
      "confinement": "classic"
    },
    "isUseTemplateApp": true
  },
  "arch": ***,
  "packager": "<stripped sensitive data>",
  "publishConfig": {
    "provider": "snapStore"
  }
},
  publishConfig: {
  "provider": "snapStore"
}
2025-0***-***2T***2:57:***8.6***7Z electron-builder:publish Create publisher: {
  "provider": "snapStore"
}

    at genericNodeError (node:internal/errors:984:***5)
    at wrappedFn (node:internal/errors:538:***4)
    at ChildProcess.exithandler (node:child_process:4[22](https://github.com/electerm/electerm/actions/runs/12733681742/job/35490334018#step:9:23):***2)
    at ChildProcess.emit (node:events:5***8:28)
    at maybeClose (node:internal/child_process:***04:***6)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5) {
  code: ***,
  killed: false,
  signal: null,
  cmd: '/home/runner/work/electerm/electerm/node_modules/.bin/electron-builder --linux snap -p always'
}
54s
Run snapcraft upload --release=edge dist/*.snap
Uploading... (--->)
Uploading... (<---)
Status: processing
Status: processing
Status: processing
Status: processing
Status: processing
Status: processing
Status: processing
Status: processing
Status: processing
Status: processing
Status: processing
Status: processing
Status: processing
Status: processing
Status: processing
Status: released
Revision 490 created for 'electerm' and released to 'edge'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants