Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji reactions cause phantom pushes on EX #2844

Closed
ara4n opened this issue Nov 28, 2024 · 3 comments
Closed

Emoji reactions cause phantom pushes on EX #2844

ara4n opened this issue Nov 28, 2024 · 3 comments
Labels
T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems

Comments

@ara4n
Copy link
Member

ara4n commented Nov 28, 2024

Steps to reproduce

  1. Do a EW+EC -> EW+EC call
  2. Send some emoji reactions to the other person.
  3. Their EX buzzes with a blank notif every time they receive an emoji reaction in the call

Outcome

What did you expect?

Emoji reactions sent on video calls shouldn't result in mobile push notifications firing.

Operating system

No response

Browser information

No response

URL for webapp

call.element.io

Will you send logs?

No

@ara4n ara4n added the T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems label Nov 28, 2024
@Half-Shot
Copy link
Member

Half-Shot commented Dec 2, 2024

This sounds like an EX bug where it's trying to surface unrenderable timeline events as notifications? If EX can't handle rooms sending custom events, that rather screws up a lot of use cases.

@Half-Shot
Copy link
Member

Having considered this further in standup, this is likely that EX notifies on every encrypted message. I assume because we make the invalid assumption that every encrypted message should be noisy (as it might be a message?).

@robintown
Copy link
Member

I've had to reopen this manually on the Element X repo since I don't have permission to transfer: element-hq/element-x-ios#3632

@robintown robintown closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

No branches or pull requests

3 participants