Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤯 We are reinventing the wheel: WP sitemaps #7

Open
szepeviktor opened this issue Mar 5, 2021 · 2 comments
Open

🤯 We are reinventing the wheel: WP sitemaps #7

szepeviktor opened this issue Mar 5, 2021 · 2 comments

Comments

@szepeviktor
Copy link
Contributor

It seems like we write code that has already been written 😢
https://github.com/WordPress/wordpress-develop/tree/master/src/wp-includes/sitemaps

Should we use/extend WordPress sitemaps classes?
What do you think?

@szepeviktor
Copy link
Contributor Author

It is very easy to parse sitemaps and retrieve URL-s from them.

@szepeviktor szepeviktor changed the title 🤯 We are reinventing the wheel 🤯 We are reinventing the wheel: WP sitemaps Mar 5, 2021
@leonstafford
Copy link
Contributor

Definitely! Have rm’d current implementation already, as felt too complex. @john-shaffer has nicer code in leonstafford/wp2static-addon-advanced-crawling and I’ll checkout this WP stuff, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants