Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting limits without dropping datapoint #74

Open
simonelsasser opened this issue Sep 8, 2020 · 2 comments
Open

Setting limits without dropping datapoint #74

simonelsasser opened this issue Sep 8, 2020 · 2 comments

Comments

@simonelsasser
Copy link

@cnluzon we had this discussion about shortcomings of ylim and also scale_y_continuous. That they draw a wrong box plot and give wrong statistics since the data not in the plot is also not used. I knew I came across a solution before, and it is

coord_cartesian(ylim=c(0, 3))

which only adjust the visible coordinates, not the underlying data. So if you implement that one can chose x or y axis limits, please use this implementation so that there are no mistakes made by unexperienced users.

@cnluzon
Copy link
Collaborator

cnluzon commented Sep 25, 2020

Nice! I did not know about this option. Right now the plotting functions do not alter axis, it's up to the user to adjust that later on. I will keep this issue open as a reminder, will close it if implemented as an option, or if I include some quantile trimming as Rui was suggesting.

@shaorray
Copy link
Contributor

The outliers, which rarely come from the biological reads, compose of (G|C) simple repeats (sequencing errors).

It would expect to be removed before bamCoverage in the pipeline (how I understand).

Trimming quantile will shift the outliers to the value of indicated quantile, which is a compromise if the source of error is unknown.

It's better to find out the reads artefacts. Last time I simply purged any coverage larger than 16 reads stack, since even for H3K4me3 the stacking is too rare to be >12 when the overlap of reads follows a Poisson distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants