Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine different version of the Encoder interface [v2] #1735

Open
KennethEnevoldsen opened this issue Jan 8, 2025 · 0 comments
Open

Combine different version of the Encoder interface [v2] #1735

KennethEnevoldsen opened this issue Jan 8, 2025 · 0 comments

Comments

@KennethEnevoldsen
Copy link
Contributor

Currently, we have three, Encoder, EncoderWithSimilarity, EncoderWithConversationEncode.

Encoder and EncoderWithSimilarity can be combined, mentioning that similarity encodes are optional.

Encode conversation is trickier. A proposed solution is to introduce a Document, which is essentially a string if asked to be a string (implement a default aggregation), however, it is possible that the model can handle it as a conversation (would also solve the cases where retrieval documents can have titles and a body.

@KennethEnevoldsen KennethEnevoldsen changed the title Combine different version of the Encoder interface Combine different version of the Encoder interface [v2] Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant