Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange Custom Transition Behavior After Upgrade #584

Open
scottosmith opened this issue Aug 15, 2017 · 1 comment
Open

Strange Custom Transition Behavior After Upgrade #584

scottosmith opened this issue Aug 15, 2017 · 1 comment

Comments

@scottosmith
Copy link

I recently upgraded an app to the latest version of ember-cli (2.14.2) (which also required updating ember-data and ember-source) and in the process upgraded liquid-fire (went from 0.25 to 0.27.3). Since doing this, everything seems to work just fine except custom transitions. I am using one custom transition on a block {{liquid-bind}} and if I put a break point on the first line of the transition, it gets hit twice every time it's triggered. I tested on my master branch and the transition is only triggered once. Any idea why this repeat is happening? I have tried everything I can think of to get to the root of the problem and haven't made any progress. Any suggestions would be welcome.

UPDATE: while typing out this issue description, I noticed liquid-fire 0.28 was released. I upgraded and am still experiencing the issue.

@ef4
Copy link
Collaborator

ef4 commented Aug 21, 2017

What versions of ember itself (ember-source) did you upgrade between?

Changes there could have revealed timing-related weirdness in your application that would only be apparent when trying to animate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants