Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONAPISerializer: extractMeta is never called #4602

Closed
urbany opened this issue Oct 20, 2016 · 1 comment
Closed

JSONAPISerializer: extractMeta is never called #4602

urbany opened this issue Oct 20, 2016 · 1 comment

Comments

@urbany
Copy link

urbany commented Oct 20, 2016

It is called here for the JSONSerializer:
https://github.com/emberjs/data/blob/v2.9.0/addon/serializers/json.js#L461

But the JSONAPISerializer doesn't use its parent _normalizeResponse (does not call _super) nor calls extractMeta anywhere.

Is this on purpose? I'm trying to parse all the meta info to camelize the hash keys and was using the extractMeta to do this.

Thanks in advance.

@pangratz
Copy link
Member

I am closing as this is a duplicate of #4161 and the other issue has more context. Thanks for opening this issue though, this is something which definitely should be fixed. Please chime in at the other discussion.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants