Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom index.html #103

Open
sebastienros opened this issue Feb 3, 2020 · 4 comments
Open

Custom index.html #103

sebastienros opened this issue Feb 3, 2020 · 4 comments

Comments

@sebastienros
Copy link

Maybe an index.html could be generated at the root of the container, and then using the new static website feature of Azure this would be served on the main url. That could include a static page to list the packages and the versions using some SPA application. This file could also be hosted somewhere else, and be compatible with any v3 feed I assume.

@emgarten
Copy link
Owner

emgarten commented Feb 5, 2020

This would be a great feature!

index.html could be added at init/recreate time when the feed is first set up. It could read the package index json file to find all ids/versions.

I don't have a lot of recent front end experience myself so I'm going to mark this as up for grabs. I'm happy to help review any changes for this or discuss ideas.

@newbe36524
Copy link
Contributor

In my opinion.

If you want to descory the feed , maybe Nuget explorer is quite enough. https://www.microsoft.com/en-us/p/nuget-package-explorer/9wzdncrdmdm3?activetab=pivot:overviewtab#

If you want to share some key infomation about the feed. It should not belong to this tool.

@loic-sharma
Copy link

BaGet's UI is a React app that should work against any NuGet V3 API. I've deployed this UI as a static website on Azure Blob Storage before. I think there's potential here to modularize the UI so that other projects like Sleet can use it. We'd need to:

  1. Decouple the UI from BaGet
    1. Remove BaGet branding
    2. The documentation link should point to Sleet's documentation
    3. There's a few BaGet specific additions to the V3 API, like download counts and readmes. This would need to be removed for Sleet
  2. Support client-side searching on Sleet search results

I'm not a frontend expert either so I'd be open to suggestions on the best architecture to allow Sleet and BaGet to reuse the same frontend components.

@emgarten
Copy link
Owner

A common v3 feed static UI would be great.

Client side searching would probably be the biggest change for Sleet since it doesn't have search, and to drive that it might need to read the package index, which is also unique to sleet to discover all package ids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants