-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a script + github action for rebaselining tests #23146
Comments
Sounds great! |
Yeah, sounds good. It's such a pain having the size tests randomly break and then having to figure out if it's my changes or some llvm/binaryen roll. |
We could even have a github action generate the code size changes for you and add to your PR? That way you wouldn't need to make sure you have the exact |
sbc100
added a commit
to sbc100/emscripten
that referenced
this issue
Dec 14, 2024
This is just the first iteration. See emscripten-core#23146 for more plans.
sbc100
added a commit
to sbc100/emscripten
that referenced
this issue
Dec 14, 2024
This is just the first iteration. See emscripten-core#23146 for more plans.
sbc100
added a commit
to sbc100/emscripten
that referenced
this issue
Dec 14, 2024
This is just the first iteration. See emscripten-core#23146 for more plans.
sbc100
added a commit
to sbc100/emscripten
that referenced
this issue
Dec 14, 2024
This is just the first iteration. See emscripten-core#23146 for more plans.
sbc100
added a commit
to sbc100/emscripten
that referenced
this issue
Dec 17, 2024
This is just the first iteration. See emscripten-core#23146 for more plans.
sbc100
added a commit
that referenced
this issue
Dec 17, 2024
This is just the first iteration. See #23146 for more plans.
For usage of the initial version of this script: #23188 |
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this issue
Dec 18, 2024
…-core#23162) This is just the first iteration. See emscripten-core#23146 for more plans.
This was referenced Dec 18, 2024
sbc100
added a commit
that referenced
this issue
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a bunch of codesize tests that need to be rebaselined. This need can occur under 2 different circumstances.
I think it would be good if we can avoid mixing (1) and (2). These means that the main branch should always be updated to include changes from llvm/binaryen before the changes for specific PR are landed (as part of that PR).
For (1) procedure I've been using looks something like this:
There are several problems with this (as pointed out in #23126 (comment)).
git diff
) exactly what effect the changes have.I propose adding a new script that performs most of the step above that will have the following advantages:
test xxx regressed by 10 bytes (0.1%)
).tot
).The text was updated successfully, but these errors were encountered: