Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fails with gcc-14: hal_core/utilities/utils.h (needs to include <algorithm> #602

Open
paparodeo opened this issue Dec 26, 2024 · 0 comments

Comments

@paparodeo
Copy link

Describe the bug

log

/build/source/include/hal_core/utilities/utils.h:84:18: error: 'sort' is not a member of 'std'; did you mean 'qsort'?
   84 |             std::sort(vec_1.begin(), vec_1.end());
      |                  ^~~~
      |                  qsort
/build/source/include/hal_core/utilities/utils.h:85:18: error: 'sort' is not a member of 'std'; did you mean 'qsort'?
   85 |             std::sort(vec_2.begin(), vec_2.end());
      |                  ^~~~
      |                  qsort
/build/source/include/hal_core/utilities/utils.h: In function 'bool hal::utils::is_digits(const T&)':
/build/source/include/hal_core/utilities/utils.h:187:25: error: 'all_of' is not a member of 'std'
  187 |             return std::all_of(s.begin(), s.end(), ::isdigit);
      |                         ^~~~~~
/build/source/include/hal_core/utilities/utils.h: In function 'T hal::utils::to_upper(const T&)':
/build/source/include/hal_core/utilities/utils.h:465:18: error: 'transform' is not a member of 'std'
  465 |             std::transform(result.begin(), result.end(), result.begin(), [](char c) { return std::toupper(c); });
      |                  ^~~~~~~~~
/build/source/include/hal_core/utilities/utils.h: In function 'T hal::utils::to_lower(const T&)':
/build/source/include/hal_core/utilities/utils.h:479:18: error: 'transform' is not a member of 'std'
  479 |             std::transform(result.begin(), result.end(), result.begin(), [](char c) { return std::tolower(c); });
      |                  ^~~~~~~~~

including <algorithm> in utils.h fixes the build
version: 4.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant