Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for custom_content is missing from gpt4 handler #179

Open
roman-romanov-o opened this issue Nov 27, 2024 · 1 comment
Open

Validation for custom_content is missing from gpt4 handler #179

roman-romanov-o opened this issue Nov 27, 2024 · 1 comment
Assignees

Comments

@roman-romanov-o
Copy link
Collaborator

roman-romanov-o commented Nov 27, 2024

If you pass custom_content (image attachments) and image content parts into gpt-4 handler, no error will be raised, image will be just ignored.
That's bad UX.

@adubovik
Copy link
Collaborator

adubovik commented Dec 6, 2024

Be careful to check only the DIAL extensions to the OpenAI API - e.g. custom_content and image content parts with DIAL URLs.

The image content parts with regular URLs may be just fine, since we really don't know the capabilities of the model, which fall into the catch-all-gpt4 category. It may be GPT-4.5 that supports all kinds of yet unknown modalities, and we should try to proxy the upstream as faithfully as possible. So that even older versions of adapter-openai could be used as proxies for the bleeding edge OpenAI models...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants