-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more focused dependency options? #124
Comments
My main worry here would be the added burden of maintenance with two separate packages (requiring integration tests spanning both packages). Not insurmountable but worth considering if the benefits from splitting outweighs these drawbacks. That said both the downloading and plotting functions could probably stand on their own and have separate dependencies. Currently |
A split that I could see make sense (and perhaps what you meant initially, @pearsonca) would be one package ( |
That's exactly what I want ideally. However, I was proposing something relative to maintaining backwards compatibility - I just want the mixing, but as written socialmixr also does the other stuff. To maintain backwards compat, one solution would be to introduce a new package which just does the mixing, and then have socialmixr then be a thin wrapper to that package (in addition to continuing to provide the survey-related functionality). I imagine there would also be a use for an independent surveys related data package, and then socialmixr would be a thin wrapper for that as well, but that's not my particular use case. |
I'm using
socialmixr
in a little analysis, purely for its contact matrix manipulation functionality. Addingsocialmixr
ended up actually adding 22 package dependencies, which don't really seem relevant to my use of the package. Feels like a lot.What might be a nice solution here is something like the core calculation(s) (e.g. looking at a single population demography + contact pattern data) extracted into a
smixrlite
package which provides only the math and none of the (useful, but potentially superfluous for some users) other capabilities.socialmixr
could then wrap those core capabilities with the current interface.The text was updated successfully, but these errors were encountered: