:ObisidianToggleCheckbox no longer creates a checkbox for a line without a checkbox

[when-harry-met-sally]

🐛 Describe the bug

:ObisidianToggleCheckbox previously would create a checkbox at the start of a line without a checkbox, and toggle when the checkbox exists. While the toggling behavior is the same, it seems like the checkbox creation no longer occurs.

Config

return {
"epwalsh/obsidian.nvim",
version = "*", -- recommended, use latest release instead of latest commit
lazy = false,
ft = "markdown",
-- Replace the above line with this if you only want to load obsidian.nvim for markdown files in your vault:
-- event = {
-- -- If you want to use the home shortcut '' here you need to call 'vim.fn.expand'.
-- -- E.g. "BufReadPre " .. vim.fn.expand "" .. "/my-vault/.md"
-- "BufReadPre path/to/my-vault/.md",
-- "BufNewFile path/to/my-vault/**.md",
-- },
dependencies = {
-- Required.
"nvim-lua/plenary.nvim",
"hrsh7th/nvim-cmp",

-- see below for full list of optional dependencies 👇

},
opts = {

-- A list of workspace names, paths, and configuration overrides.
-- If you use the Obsidian app, the 'path' of a workspace should generally be
-- your vault root (where the `.obsidian` folder is located).
-- When obsidian.nvim is loaded by your plugin manager, it will automatically set
-- the workspace to the first workspace in the list whose `path` is a parent of the
-- current markdown file being edited.
workspaces = {
  {
    name = "personal",
    path = "~/vaults/personal",
  },
},

-- Alternatively - and for backwards compatibility - you can set 'dir' to a single path instead of
-- 'workspaces'. For example:
-- dir = "~/vaults/work",

-- Optional, if you keep notes in a specific subdirectory of your vault.
notes_subdir = "notes",

-- Optional, set the log level for obsidian.nvim. This is an integer corresponding to one of the log
-- levels defined by "vim.log.levels.*".
log_level = vim.log.levels.INFO,

daily_notes = {
  -- Optional, if you keep daily notes in a separate directory.
  folder = "notes/dailies",
  -- Optional, if you want to change the date format for the ID of daily notes.
  date_format = "%Y-%m-%d",
  -- Optional, if you want to change the date format of the default alias of daily notes.
  alias_format = "%B %-d, %Y",
  -- Optional, if you want to automatically insert a template from your template directory like 'daily.md'
  template = nil,
},

-- Optional, completion of wiki links, local markdown links, and tags using nvim-cmp.
completion = {
  -- Set to false to disable completion.
  nvim_cmp = true,

  -- Trigger completion at 2 chars.
  min_chars = 2,

  -- Where to put new notes created from completion. Valid options are
  --  * "current_dir" - put new notes in same directory as the current buffer.
  --  * "notes_subdir" - put new notes in the default notes subdirectory.
  -- Either 'wiki' or 'markdown'.

  -- Control how wiki links are completed with these (mutually exclusive) options:
  --
  -- 1. Whether to add the note ID during completion.
  -- E.g. "[[Foo" completes to "[[foo|Foo]]" assuming "foo" is the ID of the note.
  -- Mutually exclusive with 'prepend_note_path' and 'use_path_only'.
  -- 3. Whether to only use paths during completion.
  -- E.g. "[[Foo" completes to "[[notes/foo]]" assuming "notes/foo.md" is the path of the note.
  -- Mutually exclusive with 'prepend_note_id' and 'prepend_note_path'.
  use_path_only = false,
},

-- Optional, configure key mappings. These are the defaults. If you don't want to set any keymappings this
-- way then set 'mappings = {}'.
mappings = {
  -- Overrides the 'gf' mapping to work on markdown/wiki links within your vault.
  ["gd"] = {
    action = function()
      return require("obsidian").util.gf_passthrough()
    end,
    opts = { noremap = false, expr = true, buffer = true },
  },
  -- Toggle check-boxes.
  ["<leader>ch"] = {
    action = function()
      return require("obsidian").util.toggle_checkbox()
    end,
    opts = { buffer = true },
  },
  ["<leader>to"] = {
    action = function()
      vim.cmd("ObsidianToday")
    end,
    opts = { noremap = true, silent = true },
  },
},

-- Optional, customize how names/IDs for new notes are created.
note_id_func = function(title)
  -- Create note IDs in a Zettelkasten format with a timestamp and a suffix.
  -- In this case a note with the title 'My new note' will be given an ID that looks
  -- like '1657296016-my-new-note', and therefore the file name '1657296016-my-new-note.md'
  local suffix = ""
  if title ~= nil then
    -- If title is given, transform it into valid file name.
    suffix = title:gsub(" ", "-"):gsub("[^A-Za-z0-9-]", ""):lower()
  else
    -- If title is nil, just add 4 random uppercase letters to the suffix.
    for _ = 1, 4 do
      suffix = suffix .. string.char(math.random(65, 90))
    end
  end
  return tostring(os.time()) .. "-" .. suffix
end,

-- Optional, customize the default name or prefix when pasting images via `:ObsidianPasteImg`.
image_name_func = function()
  -- Prefix image names with timestamp.
  return string.format("%s-", os.time())
end,

-- Optional, boolean or a function that takes a filename and returns a boolean.
-- `true` indicates that you don't want obsidian.nvim to manage frontmatter.
disable_frontmatter = false,

-- Optional, alternatively you can customize the frontmatter data.
note_frontmatter_func = function(note)
  -- Add the title of the note as an alias.
  if note.title then
    note:add_alias(note.title)
  end

  local out = { id = note.id, aliases = note.aliases, tags = note.tags }

  -- `note.metadata` contains any manually added fields in the frontmatter.
  -- So here we just make sure those fields are kept in the frontmatter.
  if note.metadata ~= nil and not vim.tbl_isempty(note.metadata) then
    for k, v in pairs(note.metadata) do
      out[k] = v
    end
  end

  return out
end,

-- Optional, for templates (see below).
templates = {
  subdir = "templates",
  date_format = "%Y-%m-%d",
  time_format = "%H:%M",
  -- A map for custom variables, the key should be the variable and the value a function
  substitutions = {
    yesterday = function()
      return os.date("%Y-%m-%d", os.time() - 86400)
    end,
  },
},

-- Optional, by default when you use `:ObsidianFollowLink` on a link to an external
-- URL it will be ignored but you can customize this behavior here.
follow_url_func = function(url)
  -- Open the URL in the default web browser.
  vim.fn.jobstart({ "open", url }) -- Mac OS
  -- vim.fn.jobstart({"xdg-open", url})  -- linux
end,

-- Optional, set to true if you use the Obsidian Advanced URI plugin.
-- https://github.com/Vinzent03/obsidian-advanced-uri
use_advanced_uri = false,

-- Optional, set to true to force ':ObsidianOpen' to bring the app to the foreground.
open_app_foreground = false,

picker = {
  -- Set your preferred picker. Can be one of 'telescope.nvim', 'fzf-lua', or 'mini.pick'.
  name = "telescope.nvim",
  -- Optional, configure key mappings for the picker. These are the defaults.
  -- Not all pickers support all mappings.
  mappings = {
    -- Create a new note from your query.
    new = "<C-x>",
    -- Insert a link to the selected note.
    insert_link = "<C-l>",
  },
},
-- Optional, sort search results by "path", "modified", "accessed", or "created".
-- The recommend value is "modified" and `true` for `sort_reversed`, which means, for example,
-- that `:ObsidianQuickSwitch` will show the notes sorted by latest modified time
sort_by = "modified",
sort_reversed = true,

-- Optional, determines how certain commands open notes. The valid options are:
-- 1. "current" (the default) - to always open in the current window
-- 2. "vsplit" - to open in a vertical split if there's not already a vertical split
-- 3. "hsplit" - to open in a horizontal split if there's not already a horizontal split
open_notes_in = "current",

-- Optional, configure additional syntax highlighting / extmarks.
-- This requires you have `conceallevel` set to 1 or 2. See `:help conceallevel` for more details.
ui = {
  enable = true,         -- set to false to disable all additional syntax features
  update_debounce = 200, -- update delay after a text change (in milliseconds)
  -- Define how various check-boxes are displayed
  checkboxes = {
    -- NOTE: the 'char' value has to be a single character, and the highlight groups are defined below.
    [" "] = { char = "󰄱", hl_group = "ObsidianTodo" },
    ["x"] = { char = "", hl_group = "ObsidianDone" },
    [">"] = { char = "", hl_group = "ObsidianRightArrow" },
    ["~"] = { char = "󰰱", hl_group = "ObsidianTilde" },
    -- Replace the above with this if you don't have a patched font:
    -- [" "] = { char = "☐", hl_group = "ObsidianTodo" },
    -- ["x"] = { char = "✔", hl_group = "ObsidianDone" },

    -- You can also add more custom ones...
  },
  -- Use bullet marks for non-checkbox lists.
  bullets = { char = "•", hl_group = "ObsidianBullet" },
  external_link_icon = { char = "", hl_group = "ObsidianExtLinkIcon" },
  -- Replace the above with this if you don't have a patched font:
  -- external_link_icon = { char = "", hl_group = "ObsidianExtLinkIcon" },
  reference_text = { hl_group = "ObsidianRefText" },
  highlight_text = { hl_group = "ObsidianHighlightText" },
  tags = { hl_group = "ObsidianTag" },
  hl_groups = {
    -- The options are passed directly to `vim.api.nvim_set_hl()`. See `:help nvim_set_hl`.
    ObsidianTodo = { bold = true, fg = "#f78c6c" },
    ObsidianDone = { bold = true, fg = "#89ddff" },
    ObsidianRightArrow = { bold = true, fg = "#f78c6c" },
    ObsidianTilde = { bold = true, fg = "#ff5370" },
    ObsidianBullet = { bold = true, fg = "#89ddff" },
    ObsidianRefText = { underline = true, fg = "#c792ea" },
    ObsidianExtLinkIcon = { fg = "#c792ea" },
    ObsidianTag = { italic = true, fg = "#89ddff" },
    ObsidianHighlightText = { bg = "#75662e" },
  },
},

-- Specify how to handle attachments.
attachments = {
  -- The default folder to place images in via `:ObsidianPasteImg`.
  -- If this is a relative path it will be interpreted as relative to the vault root.
  -- You can always override this per image by passing a full path to the command instead of just a filename.
  img_folder = "assets/imgs", -- This is the default
  -- A function that determines the text to insert in the note when pasting an image.
  -- It takes two arguments, the `obsidian.Client` and a plenary `Path` to the image file.
  -- This is the default implementation.
  ---@param client obsidian.Client
  ---@param path Path the absolute path to the image file
  ---@return string
  img_text_func = function(client, path)
    local link_path
    local vault_relative_path = client:vault_relative_path(path)
    if vault_relative_path ~= nil then
      -- Use relative path if the image is saved in the vault dir.
      link_path = vault_relative_path
    else
      -- Otherwise use the absolute path.
      link_path = tostring(path)
    end
    local display_name = vim.fs.basename(link_path)
    return string.format("![%s](%s)", display_name, link_path)
  end,
},

-- Optional, set the YAML parser to use. The valid options are:
--  * "native" - uses a pure Lua parser that's fast but potentially misses some edge cases.
--  * "yq" - uses the command-line tool yq (https://github.com/mikefarah/yq), which is more robust
--    but much slower and needs to be installed separately.
-- In general you should be using the native parser unless you run into a bug with it, in which
-- case you can temporarily switch to the "yq" parser until the bug is fixed.
yaml_parser = "native",
-- see below for full list of options 👇

},
}

Environment

Build type: Release
LuaJIT 2.1.1702233742

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"
  
  Obsidian.nvim v3.7.7 (6661806e211bc987d68e4f0b7c92eabfe797c2eb)
Status:
  • buffer directory: nil
  • working directory: /home/miles
Workspaces:
  ✓ active workspace: Workspace(name='personal', path='/home/miles/vaults/personal', root='/home/miles/vaults/personal')
Dependencies:
  ✓ plenary.nvim: 8aad4396840be7fc42896e3011751b7609ca4119
  ✓ nvim-cmp: ce16de5665c766f39c271705b17fff06f7bcb84f
  ✓ telescope.nvim: d26b666b45e5dde23332e4bde1227677f2d92e31
Integrations:
  ✓ picker: TelescopePicker()
  ✓ completion: enabled (nvim-cmp) ✗ refs, ✗ tags, ✗ new
    all sources:
      • copilot
      • nvim_lsp
      • path
      • buffer
      • luasnip
Tools:
  ✓ rg: ripgrep 14.1.0
Environment:
  • operating system: Linux
Config:
  • notes_subdir: notes
Error detected while processing command line:
E138: All /home/miles/.local/state/nvim/shada/main.shada.tmp.X files exist, cannot write ShaDa file!%

  
  

[CaeChao]

It seems like it is caused by my merge here
I only thought about cycling through the checkbox options and forgot to put the original condition back for backwards compatibility, should be able to put the function back with the fix here. I also omit the create new checkbox part for :ObisidianToggleCheckbox command here, I think it would be nice to have an option only cycle through checkbox options instead of creating a new one