Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Exported hook and validation types #10

Open
adam-alchemy opened this issue Dec 1, 2023 · 2 comments
Open

[Improvement] Exported hook and validation types #10

adam-alchemy opened this issue Dec 1, 2023 · 2 comments

Comments

@adam-alchemy
Copy link

  • The manifest is limited in how it can define plugin functions, since every entry within it is used to add a step to the “installation procedure” - AKA what changes need to be made to the account state. This causes some tricky-to-handle cases when combined with the user-supplied install config fields (dependencies and injected hooks, see [Improvement] User-supplied install config #9): How can a plugin declare a function that it implements, intended to be used for other plugins’ dependencies and/or hooks, without the plugin putting this into the manifest itself as a thing to install? There may not be an opportunity or reason to install a validation function/hook yet, if its purpose is to provide that function to be used by other plugins.
  • The plugin could “declare” functions it provides, either in the manifest or somewhere else, that may be used by other plugins as part of the user-supplied install config.
  • If we think it is valuable, we could even add install state validation to this, ensuring only known & installed functions are applied via user-supplied install configs.
@jaypaik
Copy link
Contributor

jaypaik commented Dec 18, 2023

This seems useful, and perhaps an extension of this also covers execution functions. It seems there isn't a good way to declare a dependency on an execution function for the executeFromPlugin use case currently.

We had this before when dependencies were just plugin addresses (ethereum/EIPs#7516), but with the update to change dependencies to FunctionReferences, we now only allow associated functions to be declared as dependencies.

@jaypaik
Copy link
Contributor

jaypaik commented Dec 18, 2023

Related: #22

@jaypaik jaypaik added this to the Simplify PluginManifest milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants