Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Batch operations with validation reuse #12

Open
adam-alchemy opened this issue Dec 1, 2023 · 1 comment · Fixed by erc6900/reference-implementation#78

Comments

@adam-alchemy
Copy link

(Brought up in old Spec Update 3 discussions and again by Ross in eth-magicians)

  • Currently, generalized batched operations are only possible with self-calls through executeBatch. These are clumsy and somewhat inefficient, for two reasons:
    • The ability for self-calls to always be validated is not part of the spec, but has been the behavior of the ownership plugins. This may not always be the case for other ownership plugins.
    • This causes runtime validation to be run once per item in the batch. This is needlessly wasteful, usually the actions within this cal be collectively validated and reused. However, managing this authorization data is tricky, because a naive implementation like multicall would result in the validation function over multicall itself to implicitly be a validation function for everything.
@adamegyed
Copy link

Addressed in this PR: erc6900/reference-implementation#78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants