-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte h2j not working with v4. #2
Comments
In My opinion, it is caused due to svelte dropped @jasongitmail For test just use
Error: Cannot find module '../data/patch.json'
Require stack:
- /Users/shivammeena/WebstormProjects/svelte-h2j/.svelte-kit/output/server/entries/endpoints/_server.ts.js
at Module._resolveFilename (node:internal/modules/cjs/loader:995:15)
at Module._load (node:internal/modules/cjs/loader:841:27)
at Module.require (node:internal/modules/cjs/loader:1061:19)
at require (node:internal/modules/cjs/helpers:103:18)
at file:///Users/shivammeena/WebstormProjects/svelte-h2j/.svelte-kit/output/server/entries/endpoints/_server.ts.js:11565:15
at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
at async Promise.all (index 0)
at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
at async analyse (file:///Users/shivammeena/WebstormProjects/svelte-h2j/node_modules/.pnpm/@sveltejs+kit@1.24.0_svelte@4.0.0_vite@4.4.9/node_modules/@sveltejs/kit/src/core/postbuild/analyse.js:83:16)
at async MessagePort.<anonymous> (file:///Users/shivammeena/WebstormProjects/svelte-h2j/node_modules/.pnpm/@sveltejs+kit@1.24.0_svelte@4.0.0_vite@4.4.9/node_modules/@sveltejs/kit/src/utils/fork.js:22:16)
Emitted 'error' event on Worker instance at:
at [kOnErrorMessage] (node:internal/worker:290:10)
at [kOnMessage] (node:internal/worker:301:37)
at MessagePort.<anonymous> (node:internal/worker:202:57)
at [nodejs.internal.kHybridDispatch] (node:internal/event_target:731:20)
at exports.emitMessage (node:internal/per_context/messageport:23:28) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/Users/shivammeena/WebstormProjects/svelte-h2j/.svelte-kit/output/server/entries/endpoints/_server.ts.js'
]
}
Node.js v18.12.1 You can try it, if you need any help, i'll available in the evening |
There are two extensions on the file |
You can try with it but i didn't found it like that. |
The build error is due to the import on line 1 within Steps I took:
export function toReactElement(htmlString: string): void {
return;
} and the build error still occurs.
|
Yes, only in server context. On client it works so we can do something with vite optimizations.
Already posted in svelte and kit ask
Yes, but second thing came in mind was why did they chose jsx in first place? We can make a request but i doubt they will consider it as they didn't considered As of now we can implement this with |
@jasongitmail i think opening a issue on svelte/kit project will be better to get a solution for this. |
Because Vercel created Satori and came about when Vercel supported NextJS as the only framework. JSX is the right choice for a React-based project. But now Vercel has hired Rich and others to work on SvelteKit, so now Vercel should have a different, new motivation for Satori to support all the frameworks that Vercel does--including SvelteKit. |
I'll try again vercel/satori#188 |
I just posted on Satori to see if they would consider official support, given Vercel now supports SvelteKit vercel/satori#558 |
@jasongitmail please check |
We are able to make a package but not able to make a build for preview or anthing. Check v3 and main branch of the project.
The text was updated successfully, but these errors were encountered: