General issue of abaplint with FOR...IN... ? Scrabble Score

[mickrig]

It seems there is a general issue using FOR...IN... maybe only in combination with REDUCE.
Can you please check the issue?

In my local environment the code works well.

    DATA letter TYPE c.
    DATA offset TYPE i.
    DATA char_tab TYPE STANDARD TABLE OF c WITH EMPTY KEY.

    DO.
      TRY.
          letter = substring( val = input
                              off = offset
                              len = 1 ).
          offset += 1.
          APPEND to_upper( letter ) TO char_tab.

        CATCH cx_sy_range_out_of_bounds.
          EXIT.
      ENDTRY.
    ENDDO.

    result = REDUCE i(
      INIT score TYPE i
      FOR char IN char_tab
      NEXT score = score + COND #(
                     WHEN matches( val = char pcre = `[AEIOULNRST]` )
                       THEN 1
                     WHEN matches( val = char pcre = `[DG]` )
                       THEN 2
                     WHEN matches( val = char pcre = `[BCMP]` )
                       THEN 3
                     WHEN matches( val = char pcre = `[FHVWY]` )
                       THEN 4
                     WHEN matches( val = char pcre = `[K]` )
                       THEN 5
                     WHEN matches( val = char pcre = `[JX]` )
                       THEN 8
                     WHEN matches( val = char pcre = `[QZ]` )
                       THEN 10 ) ).

[larshp]

thanks

at first sight I think its an issue with "pcre", try using old style "regex" instead in matches

https://github.com/abaplint/transpiler/blob/main/packages/runtime/src/builtin/matches.ts
https://github.com/abaplint/transpiler/blob/main/test/builtin/matches.ts

[mickrig]

Hi Lars, thanks for your feedback. But as you can see on the screenshot I provided there is no issue regarding matches.
I got the same error without using matches in my .

[larshp]

okay rename variable "char" to something else, it is a reserved keyword in JavaScript, which is the runtime. In the future it will automatically workaround this restriction

[larshp]

I dont see the screenshot, here is a screenshot of the broken screenshot,

[larshp]

after renaming,

  METHOD score.
    DATA letter TYPE c.
    DATA offset TYPE i.
    DATA char_tab TYPE STANDARD TABLE OF c WITH EMPTY KEY.

    DO.
      TRY.
          letter = substring( val = input
                              off = offset
                              len = 1 ).
          offset += 1.
          APPEND to_upper( letter ) TO char_tab.

        CATCH cx_sy_range_out_of_bounds.
          EXIT.
      ENDTRY.
    ENDDO.

    result = REDUCE i(
      INIT score TYPE i
      FOR foo IN char_tab
      NEXT score = score + COND #(
                     WHEN matches( val = foo pcre = `[AEIOULNRST]` )
                       THEN 1
                     WHEN matches( val = foo pcre = `[DG]` )
                       THEN 2
                     WHEN matches( val = foo pcre = `[BCMP]` )
                       THEN 3
                     WHEN matches( val = foo pcre = `[FHVWY]` )
                       THEN 4
                     WHEN matches( val = foo pcre = `[K]` )
                       THEN 5
                     WHEN matches( val = foo pcre = `[JX]` )
                       THEN 8
                     WHEN matches( val = foo pcre = `[QZ]` )
                       THEN 10 ) ).
  ENDMETHOD.

[larshp]

abaplint/transpiler#883

[larshp]

now better error message,

[larshp]

and using regex,

[larshp]

try again

its not perfect, but better. Helping with fixes is welcome.

Currently I'm trying to not have totally misleading error messages, and getting code run with correct results

[mickrig]

Thanks Lars, with the provided corrections the code works now on exercism. Thanks.