Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

OpenTelemetry API changing soon #1

Open
dyladan opened this issue Jan 16, 2020 · 5 comments
Open

OpenTelemetry API changing soon #1

dyladan opened this issue Jan 16, 2020 · 5 comments

Comments

@dyladan
Copy link

dyladan commented Jan 16, 2020

Hello, I am one of the maintainers of OpenTelemetry JS and I noticed that you took us on as a dependency. I just wanted to reach out and let you know that we're available in the https://gitter.im/open-telemetry/opentelemetry-node gitter channel and that we're happy to work with you if you run into any challenges.

One that we expect you will run into soon is that we're changing the public facing API soon. Instead of registering a global tracer, you will need to register a global tracer factory/provider/registry (name still subject to change), then from there you acquire a tracer by calling getTracer with the name and version of your library. In your case, it would be getTracer('@expresso/tracing', '1.0.5').

This may be a particular issue for you, as I noticed that you've installed us using the version scheme ^0.3.2 in your package.json, which means any install could get any version we publish before 1.0. Since we are still in alpha, we expect that there may be further API changes.

Mentioning @mayurkale22 so he also sees this. If you have any questions feel free to reach out (or just reply here). Cheers!

@roziscoding
Copy link
Member

Hi, @dyladan. Thanks for the heads up! I'll set the version to fixed one until I get the time to make the necessary API changes and check to see how they'll affect the library's API.

Again, thanks for reaching out!

@dyladan
Copy link
Author

dyladan commented Jan 19, 2020

No problem, it should be very soon. I'll comment here when the new API is available.

@roziscoding
Copy link
Member

Just spent half an hour trying to realize what was wrong until I thought about this issue, 'cause I didn't change the version haha

@dyladan
Copy link
Author

dyladan commented Feb 15, 2020

oh no I'm sorry I forgot to comment :/

@roziscoding
Copy link
Member

that's alright
the main problem was the internal modules updating, eevn though I set the version to 0.3.2 on my package
I commented about this on an issue in the OpenTelemetry repo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants