Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seperate ExtismPointer from handle #19

Closed
4 tasks done
G4Vi opened this issue Dec 22, 2023 · 1 comment · Fixed by #18
Closed
4 tasks done

Seperate ExtismPointer from handle #19

G4Vi opened this issue Dec 22, 2023 · 1 comment · Fixed by #18

Comments

@G4Vi
Copy link
Contributor

G4Vi commented Dec 22, 2023 •
edited
Loading

ExtismPointer can currently refers to three different things:

  • a pointer in extism memory
  • an offset in input memory
  • a pointer in extism memory to the start of data in a memory block

By introducing a new type ExtismHandle for the last item, the api can be made easier to use correctly.

  • Add new type to header ExtismHandle
  • Get all tests and examples running.
  • Update docs
  • Make extism length fast again.

PR: #18
@G4Vi
Copy link
Contributor Author

G4Vi commented Jan 3, 2024 •
edited
Loading

Once extism_length_unsafe is available, the pdk can be updated to use it for extism_length (as it takes an ExtismHandle here) and this can be completed.

extism/extism#643

@G4Vi G4Vi mentioned this issue Jan 3, 2024
Merged
@G4Vi G4Vi closed this as completed in #18 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: seperate pointer from handle extism/c-pdk
1 participant
@G4Vi