Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Great collaboration stats and other comments #45

Open
helenzhou6 opened this issue Mar 29, 2018 · 2 comments
Open

Great collaboration stats and other comments #45

helenzhou6 opened this issue Mar 29, 2018 · 2 comments
Labels
compliment

Comments

@helenzhou6
Copy link

helenzhou6 commented Mar 29, 2018 •
edited
Loading

Hey guys! 👋

I really love the look at your site!

  • The use of grid is awesome 👌 (making it mobile friendly too).
  • Great use of BEM in your styling
  • 💯on accessibility nice!

screen shot 2018-03-29 at 10 18 30

  • Also you handled 'No results found!' which is awesome!

  • Nice favicon 😊

  • The loading spinner is also very neat :)

  • And finally your collaboration stats are nice and even:

screen shot 2018-03-29 at 10 13 33

  • Travis badge on README is cool

  • And passing your tests 👍

  • And use of error-first callbacks - very jealous

  • Good use of error handling in your handler.js file too

  • Your index.js is commented well, and well sectioned.

This is really hard to criticise 😅 Great job! 😍
@helenzhou6 helenzhou6 changed the title Great collaboration stats Great collaboration stats and other comments Mar 29, 2018
@n1c0z
Copy link
Collaborator

n1c0z commented Mar 29, 2018

Thank you. 👍

@n1c0z
Copy link
Collaborator

n1c0z commented Mar 29, 2018

Likewise for you awesome project! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compliment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@n1c0z @helenzhou6 @Parissai