Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple GCS file system instances #12058

Open
majetideepak opened this issue Jan 10, 2025 · 3 comments
Open

Add support for multiple GCS file system instances #12058

majetideepak opened this issue Jan 10, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@majetideepak
Copy link
Collaborator

Description

Currently only one is supported
https://github.com/facebookincubator/velox/blob/main/velox/connectors/hive/storage_adapters/gcs/RegisterGcsFileSystem.cpp

@majetideepak majetideepak added the enhancement New feature or request label Jan 10, 2025
@majetideepak
Copy link
Collaborator Author

@JkSelf will you be able to help with this?

@JkSelf
Copy link
Collaborator

JkSelf commented Jan 14, 2025

@majetideepak Yes. I will follow up this issue. Thanks.

@JkSelf
Copy link
Collaborator

JkSelf commented Jan 17, 2025

@majetideepak I successfully compiled the GCS test in my local environment using the following command:
make release NUM_THREADS=110 MAX_HIGH_MEM_JOBS=110 MAX_LINK_JOBS=110 'EXTRA_CMAKE_FLAGS=-DCMAKE_CXX_FLAGS="-Wno-missing-field-initializers" -DVELOX_ENABLE_PARQUET=ON -DVELOX_BUILD_TESTING=ON -DVELOX_MONO_LIBRARY=ON -DVELOX_BUILD_RUNNER=OFF -DVELOX_ENABLE_GCS=ON -DCMAKE_BUILD_TYPE=Release'

However, I encountered an issue when running the unit test. The following exception was thrown:

root@sr249:/home/lab01/velox# ./_build/release/velox/connectors/hive/storage_adapters/gcs/tests/velox_gcsfile_test --gtest_filter=GcsFileSystemTest.readFile
Running main() from /mnt/DP_disk1/code/gluten/ep/build-velox/build/velox_ep/_build/release/_deps/gtest-src/googletest/src/gtest_main.cc
Note: Google Test filter = GcsFileSystemTest.readFile
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from GcsFileSystemTest
[ RUN      ] GcsFileSystemTest.readFile
/home/lab01/velox/./velox/connectors/hive/storage_adapters/gcs/tests/GcsEmulator.h:125: Failure
Value of: bucket.ok()
  Actual: false
Expected: true
Failed to create bucket <test1-gcs>, status=PERMISSION_DENIED: Permanent error, with a last message of <!-- IE friendly error message walkround.
     if error message from server is less than
     512 bytes IE v5+ will use its own error
     message instead of the one returned by
     server.                                 -->

Do you have any suggestions on how to resolve this issue? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants