Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of innerHtml #20

Open
ZooeyMiller opened this issue Jul 27, 2017 · 0 comments
Open

Use of innerHtml #20

ZooeyMiller opened this issue Jul 27, 2017 · 0 comments

Comments

@ZooeyMiller
Copy link

It is generally considered good practice to avoid using innerHtml ever.

Use of innerHtml can amke your sit vulnerable to hacking, and it is far less performant than using appendChild.

I would heavily recommend that you alter the code on line 31 of script.js to remove the use of innerHtml and change it to use something like appendChild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant