Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of forEach rather than map #7

Open
ZooeyMiller opened this issue Jul 27, 2017 · 1 comment
Open

Use of forEach rather than map #7

ZooeyMiller opened this issue Jul 27, 2017 · 1 comment

Comments

@ZooeyMiller
Copy link

From line 56 of handlers.js https://github.com/facn2/PHS/blob/master/src/handlers.js#L56 you are using a forEach to loop through an array of objects and push one property from that object into another array. This would be a really good use case for map

@ghost
Copy link

ghost commented Jul 27, 2017

agreed - will look into this

@ghost ghost self-assigned this Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant