Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validateLogin function is inconsistent #59

Open
mattlub opened this issue Aug 17, 2017 · 0 comments
Open

validateLogin function is inconsistent #59

mattlub opened this issue Aug 17, 2017 · 0 comments

Comments

@mattlub
Copy link

mattlub commented Aug 17, 2017

https://github.com/facn2/facnrecipe2.0/blob/master/src/queries/userData.js#L51-L75

It seems to me that the following 2 cases should both either pass an error or both not

return callback(null, 'Incorrect username')
return callback('incorrect password')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant