error handling middleware

[mattlub]

your error handling middleware has very good intentions, but I don't think it works currently right?

https://github.com/facn2/facnrecipev4/blob/master/src/controllers/error.js

See express docs for more: http://expressjs.com/en/guide/error-handling.html

Or see here for a working example:

1. passing on the error with next:
   https://github.com/foundersandcoders/open-tourism-platform/blob/master/src/controllers/event.js#L7-L14
2. dealing with the error with error-handling middleware:
   https://github.com/foundersandcoders/open-tourism-platform/blob/master/src/middleware/finalErrorHandler.js

[tyeung2017]

it actually works.

we apply it using app.use in controller/index.js

actually we copy it from the workshop. haha

[mattlub]

you shouldn't be responding to issues yet... 😉

[mattlub]

interesting. link me the workshop please when you come to responding to issues

[mattlub]

ok. I think this is defunct becuase the previous line always sends a response? Or is express doing something under the hood?

[mattlub]

I think I see what you're doing now, but using express error-handling middleware would be a better way to do it, check the docs and the link from the first comment.

[mattlub]

how can I see what you did to resolve this issue?

[mattlub]

and why did you close it?