Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HybridisationSCPC after assemble(..., zero_bc_nodes=True) updates. #213

Open
JHopeCollins opened this issue Jan 20, 2025 · 0 comments
Open

Fix HybridisationSCPC after assemble(..., zero_bc_nodes=True) updates. #213

JHopeCollins opened this issue Jan 20, 2025 · 0 comments
Assignees
@JHopeCollins
Labels
bug Something isn't working PRIORITY Needs urgent attention upstream Issue related to upstream dependencies

Comments

@JHopeCollins
Copy link
Member

The firedrake PR that changed how assemble treats boundary nodes broke the HybridisationSCPC in some way. It runs without error but the tests are failing because the solver diverges.

I have xfailed those tests for now because we urgently need to merge the other fixes into master. However, this PC is really important because it can handle hybridising the forms generated by complex_proxy, which the firedrake HybridizationPC cannot. It should be fixed ASAP.
@JHopeCollins JHopeCollins added bug Something isn't working PRIORITY Needs urgent attention upstream Issue related to upstream dependencies labels Jan 20, 2025
@JHopeCollins JHopeCollins self-assigned this Jan 20, 2025
@JHopeCollins JHopeCollins mentioned this issue Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JHopeCollins JHopeCollins

Labels
bug Something isn't working PRIORITY Needs urgent attention upstream Issue related to upstream dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JHopeCollins