Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShowQuickAccessToolBarAboveRibbon="False" causes crash #463

Closed
dady8889 opened this issue Aug 23, 2017 · 5 comments
Closed

ShowQuickAccessToolBarAboveRibbon="False" causes crash #463

dady8889 opened this issue Aug 23, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@dady8889
Copy link
Contributor

dady8889 commented Aug 23, 2017

As title says, it causes

System.InvalidOperationException: 'Specified element is already the logical child of another element. Disconnect it first.

Reproduction:
Put ShowQuickAccessToolBarAboveRibbon="False" into your Ribbon control. Tested on latest showcase.


Environment

  • Fluent.Ribbon Latest develop head
  • Windows 10
  • .NET Framework 4.5.2
@batzen
Copy link
Member

batzen commented Aug 23, 2017

Can't reproduce this using the latest source version.

@dady8889
Copy link
Contributor Author

I've just recloned the repo to be sure and went to TestContent.xaml in Fluent.Ribbon 4.5 Showcase and put it in the ribbon control. The error occurs from PresentationFramework.dll and my version is v4.0.30319, probably it's a factor. I use VS 2017. I have fixed it in the code, however I doubt it's the correct way of fixing it.
error1

@batzen
Copy link
Member

batzen commented Aug 23, 2017

and put it in the ribbon control.

What does that mean?

@dady8889
Copy link
Contributor Author

I mean, when I put ShowQuickAccessToolBarAboveRibbon="False" as an attribute inside the ribbon control initial tags. I have noticed that it indeed does work when you change the attribute in the showcase using the checkbox.

@batzen
Copy link
Member

batzen commented Aug 23, 2017

Ah, will try to reproduce it that way tomorrow.

@batzen batzen self-assigned this Aug 24, 2017
@batzen batzen added this to the 6.0.0 milestone Aug 24, 2017
@batzen batzen closed this as completed in b6db124 Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants