Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create XAML icons and replace the shipped pngs with these #650

Closed
batzen opened this issue Oct 7, 2018 · 18 comments
Closed

Create XAML icons and replace the shipped pngs with these #650

batzen opened this issue Oct 7, 2018 · 18 comments

Comments

@batzen
Copy link
Member

batzen commented Oct 7, 2018

We need to convert the shipped pngs to xaml icons to be able to change their colors based on the current theme.
This would also solve issues like #635

Any help is greatly appreciated as i am very bad when it comes to creating icons/graphics.

@Splitwirez
Copy link
Contributor

I know this isn't a direct answer, but InkScape can trace raster images fairly well, and can then export the result to a series of WPF paths... https://inkscape.org/en/

@batzen
Copy link
Member Author

batzen commented Oct 7, 2018

I already tried that and the results looked horrible...

@Splitwirez
Copy link
Contributor

...right. I haven't used that feature much, but the one time I did use it, I got pretty good results after fiddling with the options for a few moments. In any case, though...how many icons are we talking about? 🤔

@batzen
Copy link
Member Author

batzen commented Oct 7, 2018

There are about 10 icons that would need to be converted.

@LucaFagan
Copy link

LucaFagan commented Oct 19, 2018

Convert your PNGs to SVGs and then use "Expression Blend 4" to export the vector images to xaml.

If conversion from png to svg is horribile then you have to create the icons from scratch.

I can help, where can I find those icons ?

@batzen
Copy link
Member Author

batzen commented Oct 19, 2018

@LucaFagan
Copy link

Do you need xaml icons in multicolor or in one color ?

I mean, if an icon is yellow and black (for example Warning.png) and I give you a xaml of that icon, will you be able to change the yellow and the black according to the theme ?

@batzen
Copy link
Member Author

batzen commented Oct 20, 2018

It depends on the icon. For some icons which are black now i'd need to be able to change that to white depending on the theme. The warning icon should already look good on the dark and light background. The reason to convert all icons is that they are scaleable then.

@LucaFagan
Copy link

Do you have the icons in higher resolution? It a bit difficult to create vector images starting from low resolution raster images.

@batzen
Copy link
Member Author

batzen commented Oct 20, 2018

Sadly not. The ones in the repo are the only ones i got.

@LucaFagan
Copy link

I've created the vector version of your icons and converted into xaml.

Download is here: https://drive.google.com/open?id=1hAXIYXWeCKETSeBQiIT-RkNHkPDSKlRo

Vector icons are in VectorIcons.zip
XAML icons are in the example: TestXAMLImages.zip

I've changed some icons to a most modern design. Launch the example to see the result.

Let me now if you want some changes.

@punker76
Copy link
Member

@DenZuck That work looks really nice! 👍

@batzen
Copy link
Member Author

batzen commented Nov 25, 2018

Sorry for my late response. Will have a look at these during the next week.

@batzen
Copy link
Member Author

batzen commented Dec 3, 2018

@DenZuck
The icons look very nice. Thanks a lot for your work.
Is there some way to get those as XAML icons? Currently you exported them to png files which is not what i imagined.
I hoped to replace all png files with xaml icons so that i am able to change their colors during runtime.
I can't really do something with the ai files, or which free program can i use for those?

@LucaFagan
Copy link

Look at the TestXAMLImages.zip sample project, icons are already in xaml format.

XAML icons are defined in Icons.xaml
Icons are used in MainWindow.xaml

As I told in another message I used "Expression Blend 4" to convert .ai into xaml but you don't need to do that because they are already converted and ready to use in TestXAMLImages.zip.

@batzen
Copy link
Member Author

batzen commented Dec 3, 2018

Uh, i am sorry. Tried to change the foreground of the images in snoop, opened the solution and only saw the png files.
Will have a second look during the week.

@LucaFagan
Copy link

In first column I use your original icons, in other columns I use xaml icons in various sizes.

image

XAML icon definitions

image

XAML icon use

image

@batzen
Copy link
Member Author

batzen commented Dec 17, 2018

Thanks @DenZuck for creating those icons!
I replaced all shipped images. If you find any oddities/problems please report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants