Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickAccessToolBar not editable anymore #849

Closed
chrfin opened this issue Sep 21, 2020 · 1 comment · Fixed by #850
Closed

QuickAccessToolBar not editable anymore #849

chrfin opened this issue Sep 21, 2020 · 1 comment · Fixed by #850
Assignees
Labels
Milestone

Comments

@chrfin
Copy link
Contributor

chrfin commented Sep 21, 2020

I think since v8 (at least it did work in a previous version, as we did use that without a problem in the past) we cannot dynamically update the QuickAccessToolBar anymore. Adding or removing items from QuickAccessItems (or any other list containing those items) does not change the GUI anymore.

For adding I found a workaround by calling QuickAccessToolBar.OnApplyTemplate(), but I found no way to remove items.

To easily reproduce place the following at the end of the TestContent.xaml.cs-constructor of the showcase app:

this.buttonGreen.Click += (s, e) =>
{
    var item = new QuickAccessMenuItem();
    item.SetBinding(QuickAccessMenuItem.TargetProperty, new Binding() { Source = this.buttonGreen });
    this.ribbon.QuickAccessItems.Add(item);
    this.ribbon.QuickAccessToolBar.OnApplyTemplate(); // workouround to get it to show up
};
this.buttonYellow.Click += (s, e) => this.ribbon.QuickAccessItems.Remove(this.ribbon.QuickAccessItems.Last());

And then press the green/yellow button in the showcase app.
Green button will add an item to the drop-down-list, but only with the call to OnApplyTemplate, but the yellow button does not remove any item.


Environment

  • Fluent.Ribbon v8.0
  • Windows 10
  • .NET Core 3.x
chrfin added a commit to chrfin/Fluent.Ribbon that referenced this issue Sep 21, 2020
@chrfin chrfin mentioned this issue Sep 21, 2020
@batzen batzen self-assigned this Sep 21, 2020
@batzen batzen added this to the Next milestone Sep 21, 2020
@batzen
Copy link
Member

batzen commented Sep 21, 2020

You are totally right i broke that with 0a214c1

batzen added a commit that referenced this issue Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants