Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CSS for Phase 2 #242

Open
jhung opened this issue Dec 15, 2021 · 2 comments
Open

Clean up CSS for Phase 2 #242

jhung opened this issue Dec 15, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@jhung
Copy link
Member

jhung commented Dec 15, 2021

Is your feature request related to a problem?

In the push to have the first release, the app.css file is a bit messy.

Describe the solution you'd like

Clean-up should be done on the CSS file, and consider using a pre-processor if needed.

@jhung jhung added the enhancement New feature or request label Dec 15, 2021
@jobara
Copy link
Member

jobara commented Dec 16, 2021

The approach taken in other sites, such as the IDRC site, is to use Sass and organize it based on the 7-1 pattern. We had also hoped to model the style after Cube CSS, but that might have gotten away from us, so it would be worth reviewing this as things are moved around.

@BlueSlug
Copy link
Member

Once this work has been completed, the Contribution Guidelines (CONTRIBUTING.md) should be updated to reflect the new rules and conventions for styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants