[Housekeeping] ImageSpec Source Root: Code Already in Image, No Extra Upload Required

[taieeuu]

Describe the issue

If using imagespec source_root parameter, the code will also upload the s3.

environment

from flytekit import task, workflow, ImageSpec

import os

image_spec = ImageSpec(packages=["tensorflow", "pandas"], registry="localhost:30000", source_root=os.path.abspath("./sample") )

@task(container_image=image_spec)
def t0():
	return "hello world"

@workflow
def wf():
	t0()

if __name__ == "__main__":
	wf()

execute

pyflyte --verbose run --remote sample/pingsutw_sample_imagespec.py wf

k3s

docker container

Project/OpenSource/flytekit  k3s_copy_issue ✔                                                                                                                                                                  7d0h
▶ docker images
REPOSITORY                                                TAG                                             IMAGE ID       CREATED             SIZE
localhost:30000/flytekit                                  OSHXNX_s8klKtGf6KwfJyA                          32dd628521c1   12 minutes ago      2.2GB

docker run -d -P --name flytekit-container-source-root localhost:30000/flytekit:OSHXNX_s8klKtGf6KwfJyA tail -f /dev/null

docker exec -it <container_id> bash

flytekit@7ecc945b7528:/root$ ls
pingsutw_sample_imagespec.py
flytekit@7ecc945b7528:/root$

What if we do not do this?

optimization

Related component(s)

No response

Are you sure this issue hasn't been raised already?

• Yes

Have you read the Code of Conduct?

• Yes

[taieeuu]

#take