You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the FlytePropellor config (docs), there appears to be a bug in how the YAML file is parsed. Dots in keys are misunderstood as nested dicts. This is relevant, because e.g. Google Kubernetes Engine we might want to set an annotation: cluster-autoscaler.kubernetes.io/safe-to-evict: "false", which includes dots.
time="2025-01-14T10:33:00Z" level=error msg="\n\n\n1 error(s) decoding:\n\n* 'default-annotations[test]' expected type 'string', got unconvertible type 'map[string]interface {}', value: 'map[annotation:true]'"
This suggests that the YAML is parsed into {"default-annotations": {"test": {"annotation": "true}}} instead of {"default-annotations": {"test.annotation": "true}}, as we'd want.
Expected behavior
I'd expect the above config to lead to a default annotation test.annotation: "true", but I get a FlytePropellor error.
Additional context to reproduce
Using flyte-core 1.13.3
Screenshots
No response
Are you sure this issue hasn't been raised already?
Yes
Have you read the Code of Conduct?
Yes
The text was updated successfully, but these errors were encountered:
Describe the bug
In the FlytePropellor config (docs), there appears to be a bug in how the YAML file is parsed. Dots in keys are misunderstood as nested dicts. This is relevant, because e.g. Google Kubernetes Engine we might want to set an annotation:
cluster-autoscaler.kubernetes.io/safe-to-evict: "false"
, which includes dots.Consider the following config
This raises the following flytepropellor error:
This suggests that the YAML is parsed into
{"default-annotations": {"test": {"annotation": "true}}}
instead of{"default-annotations": {"test.annotation": "true}}
, as we'd want.Expected behavior
I'd expect the above config to lead to a default annotation
test.annotation: "true"
, but I get a FlytePropellor error.Additional context to reproduce
Using flyte-core 1.13.3
Screenshots
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: