Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] FlyteExceptions are not return user defined error_codes. #6170

Closed
2 tasks done
RRap0so opened this issue Jan 14, 2025 · 0 comments · Fixed by flyteorg/flytekit#3059
Closed
2 tasks done

[BUG] FlyteExceptions are not return user defined error_codes. #6170

RRap0so opened this issue Jan 14, 2025 · 0 comments · Fixed by flyteorg/flytekit#3059
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers

Comments

@RRap0so
Copy link
Contributor

RRap0so commented Jan 14, 2025

Describe the bug

We use FlyteUserException to pass our own error codes. These error codes are important for us for our several other services to know what they should do in different situations.

eg:

class CustomException(FlyteUserException):
    _ERROR_CODE = "USER:DoSomething"

With this PR, the behaviour as now changed to always return an hardcoded "USER" in the ContainerError and disregard if we're overriding the _ERROR_CODE with our own.

Expected behavior

Using the example above I would expect to have a ContainerError return USER:DoSomething not just USER.

Additional context to reproduce

Run a dummy task throwing a

class CustomException(FlyteUserException):
    _ERROR_CODE = "USER:DoSomething"

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant