Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items under non-tabbable shadow-roots should not be tabbable #1462

Open
Eden-Mironi-Evinced opened this issue Nov 21, 2024 · 1 comment
Open

Comments

@Eden-Mironi-Evinced
Copy link

The tabbable library identifies elements that are usually tabbable as tabbable even though that in cases the shadow root has attribute of tabIndex="-1" it should remove all of its children from the tabbing sequence.
In this case:
image
both of the buttons should not get a true value for the isTabbable function.

@stefcameron
Copy link
Member

Thanks for bringing this to my attention!

@stefcameron stefcameron changed the title Tabbable items under shadow-roots Items under non-tabbable shadow-roots should not be tabbable Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants