Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no indication of problem lines in badly-formed GFFs #11

Open
joelb123 opened this issue Oct 7, 2020 · 1 comment
Open

no indication of problem lines in badly-formed GFFs #11

joelb123 opened this issue Oct 7, 2020 · 1 comment

Comments

@joelb123
Copy link

joelb123 commented Oct 7, 2020

Running gffpandas over a badly-formed GFF doen't give any indication where the problem occurred. Line numbers in ValueError messages would be invaluable. To accomplish this, you'll have to refactor a bit. Consider adding a
line-number column to the data frame for temporary internal-only use and doing onversions in df.iterrows() or df.groupby() using try/except rather than in apply(). apply() fails silently by design, which is good for some situations but not this one.

@joelb123
Copy link
Author

joelb123 commented Oct 7, 2020

I'll also note that even a totally spurious text file (say, a FASTA instead of a GFF) does not produce an error, just no features. GFFpandas is often embedded a few layers deep, and raising an exception with a message indicating the file giving the problem would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant