Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the required aspect of the allowedContent iframe attributes #76

Open
abogaart opened this issue Apr 11, 2019 · 1 comment
Open

Comments

@abogaart
Copy link

Hi,

Is it possible to remove the required aspect of the allowedContent attributes on the iframe element? Currently, I can't upgrade the plugin to the latest version as I would have to change all existing content in our repository (add an empty attribute allow).

I'm not sure if the code really requires these attributes to be required, or if simply having them specified without the ! is already good enough.

Thanks!

@abogaart
Copy link
Author

abogaart commented Jun 7, 2022

The allowedContent rule requires the <iframe> element to have an allow attribute, but the plugin only adds this attribute if the paramAutoplay is true, meaning that if paramAutoplay is not true, the whole content will be stripped again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants