Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcli fod *-scan setup: Add --skip-if-exists option #593

Open
rsenden opened this issue Sep 13, 2024 · 1 comment
Open

fcli fod *-scan setup: Add --skip-if-exists option #593

rsenden opened this issue Sep 13, 2024 · 1 comment
Labels
effort:low Easy to implement/fix enhancement New feature or request prio:medium Medium priority

Comments

@rsenden
Copy link
Contributor

rsenden commented Sep 13, 2024

Enhancement Request

For pipeline integrations, you usually want to make sure that a scan has been set up properly to avoid scan requests from failing. However, if a scan setup already exists, we (usually) wouldn't want to override any existing setup. So, the *-scan setup commands should have a --skip-if-exists option (similar to app create and release create commands) that checks whether a scan setup already exists, and if so, skip the scan setup operation.

@rsenden rsenden added enhancement New feature or request prio:high High priority; important new feature or bug fix effort:low Easy to implement/fix labels Sep 13, 2024
@rsenden
Copy link
Contributor Author

rsenden commented Sep 16, 2024

Implemented for fcli fod sast-scan setup in 855d4f3, still needs to be implemented for other scan types. Ideally, this should be generic functionality (in a new AbstractFoDScanSetupCommand class, also see comments about the current AbstractFoDScanSetupCommand class in #598) to have a consistent implementation across scan types.

Note that for mobile, we can't check whether there's an existing scan setup (as FoD doesn't provide proper GET endpoint). If we do add a --skip-if-exists option (for example defined in a common superclass), help output should mention that this isn't available yet for mobile scans.

@rsenden rsenden added prio:medium Medium priority and removed prio:high High priority; important new feature or bug fix labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:low Easy to implement/fix enhancement New feature or request prio:medium Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant