Bug in request function when working with multipart/form-data

[gha3mi]

I found a bug with the request function when working with multipart/form-data. The second and following pairs of form variables require an extra space at the beginning!

Here is the problem: GitHub Issue #28

Thanks,
Ali

[milancurcic]

Thanks, Ali. Do you know why is the extra space needed for the 2nd and following form pairs? I suppose the change is needed here:

http-client/src/http/http_client.f90

Lines 250 to 262 in d65b4b1

	if(allocated(request%form)) then
	do i=1, size(request%form)
	if(.not. allocated(form_encoded_str)) then
	form_encoded_str = curl_easy_escape(curl_ptr, request%form(i)%name, &
	len(request%form(i)%name)) // '=' // curl_easy_escape(curl_ptr, &
	request%form(i)%value, len(request%form(i)%value))
	else
	form_encoded_str = form_encoded_str // '&' // &
	curl_easy_escape(curl_ptr, request%form(i)%name, len(request%form(i)%name))&
	// '=' // curl_easy_escape(curl_ptr, request%form(i)%value, len(request%form(i)%value))
	end if
	end do
	end if

I wonder if this has to do with how curl_easy_escape works.

[gha3mi]

Thank you for your prompt response.

My test shows that the function prepare_form_encoded_str isn't being called. I think this function should be called within the client_get_response function.

[rajkumardongre]

Hello Ali, as you are utilizing both the file and form concurrently, this code is currently operational. I will proceed to test this code:

http-client/src/http/http_client.f90

Lines 440 to 459 in d65b4b1

	else if (allocated(request%file)) then
	mime_ptr = curl_mime_init(curl_ptr)
	part_ptr = curl_mime_addpart(mime_ptr)
	status = curl_mime_filedata(part_ptr, request%file%value)
	status = curl_mime_name(part_ptr, request%file%name)
	! if both file and form are passed
	if(allocated(request%form)) then
	do i=1, size(request%form)
	part_ptr = curl_mime_addpart(mime_ptr)
	status = curl_mime_data(part_ptr, request%form(i)%value, CURL_ZERO_TERMINATED)
	status = curl_mime_name(part_ptr, request%form(i)%name)
	end do
	end if
	status = curl_easy_setopt(curl_ptr, CURLOPT_MIMEPOST, mime_ptr)
	! setting the Content-Type header to multipart/form-data, used for sending binary data
	if (.not. pair_has_name(request%header, 'Content-Type')) then
	call append_pair(request%header, 'Content-Type', 'multipart/form-data')
	end if

[gha3mi]

Thank you for your response.

This solution may not be ideal, but it works:

! if both file and form are passed
if(allocated(request%form)) then
    part_ptr = curl_mime_addpart(mime_ptr)
    status = curl_mime_data(part_ptr, request%form(1)%value, CURL_ZERO_TERMINATED)
    status = curl_mime_name(part_ptr, request%form(1)%name)
    if (size(request%form) > 1) then
        do i=2,size(request%form)
            part_ptr = curl_mime_addpart(mime_ptr)
            status = curl_mime_data(part_ptr, request%form(i)%value, CURL_ZERO_TERMINATED)
            status = curl_mime_name(part_ptr, " "//request%form(i)%name)
        end do
    end if
end if