Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difference between code and paper for sequence construction in AR-RNTR #9

Open
ZJWang9928 opened this issue Apr 12, 2024 · 2 comments
Open

Difference between code and paper for sequence construction in AR-RNTR #9

ZJWang9928 opened this issue Apr 12, 2024 · 2 comments

Comments

@ZJWang9928
Copy link

Hello! I found that the implementations of category and index of parent for sequence construction in AR-RNTR are different between your released code and the paper. Are they equivalent?
image
@EchoQiHeng
Copy link

Hello! I found that the implementations of category and index of parent for sequence construction in AR-RNTR are different between your released code and the paper. Are they equivalent? image

"Seq2bznodelist" seems to have not been called

@ZJWang9928
Copy link
Author

Hello! I found that the implementations of category and index of parent for sequence construction in AR-RNTR are different between your released code and the paper. Are they equivalent? image

"Seq2bznodelist" seems to have not been called

@EchoQiHeng
It is called in simple_test_pts function. Besides, all of the topo types are set to start, continue, fork and merge instead of Ancestor, Lineal, Offshoot and Clone. And the integer for the index of parent are implemented as fork from and merge into in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZJWang9928 @EchoQiHeng