Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing word in help command #84

Open
chiptus opened this issue Jul 27, 2017 · 3 comments
Open

missing word in help command #84

chiptus opened this issue Jul 27, 2017 · 3 comments

Comments

@chiptus
Copy link

chiptus commented Jul 27, 2017

image

I think this should be The client supports variables which can be assigned.
I would love to fix that, just to get to know the codebase :)

@nitzantomer
Copy link
Member

nitzantomer commented Jul 27, 2017

@chiptus
Yeah, you're right, there's a missing be in there.
Feel free to open a PR for fixing it, but I doubt that it will help you get to know the codebase, it's just a markdown file.

It can be found here:
https://github.com/fugazi-io/webclient/blob/master/modules/markdown/help/help.md#variables
(the module for the entire help part is this: https://github.com/fugazi-io/webclient/blob/master/modules/jsons/help.json)

Are you looking for an issue with more "meat" on it in order to delve into the code? If so, we can probably hook you up with something :)

@chiptus
Copy link
Author

chiptus commented Jul 28, 2017

@nitzantomer of course it's easy :) anyway I'll fork it and see if I can get a local environment to work. And yes I would like to have something to fix

@nitzantomer
Copy link
Member

@chiptus
I've been told that the info about how to run the local environment doesn't work, and I still haven't had the time to get into it.
BUT you can try to work with the next version using this branch: https://github.com/fugazi-io/webclient/tree/release/1.1.0
This version uses modules (import/export) and I know for a fact that the dev environment works out of the box, just do: npm run dev.
More info about the changes in this version can be found here: #83

(sorry for the mess)

As for something to fix, here are 3 open issues that you can look into:

They will all require you to get deep into the code.
Feel free to ask questions in gitter: https://gitter.im/fugazi-io/Lobby and I'll try to respond asap.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants