Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon on Chat.SE with "default" host does not show the number intermittently due to CORS #4

Open
andrew-tc opened this issue Jul 21, 2020 · 2 comments

Comments

@andrew-tc
Copy link
Contributor

The favicon on chat rooms hosted on SE sites (e.g. Android.SE, Anime.SE, etc.) shows the number correctly, but not for chat rooms with the "default" host that only shows the SE logo.

The original link is

https://cdn.sstatic.net/stackexchange/img/favicon.ico?v=dc

which is available, but not matched on the existing CORS trick

https://cdn.sstatic.net/Sites/*/favicon.ico*

missing /Sites in the path.

There is also

https://cdn.sstatic.net/Sites/stackexchange/img/favicon.ico?v=dc

which is 32x32 compared to 16x16 from the original link.


There are 2 possible solutions:

  1. Add a new pattern for CORS trick
  2. Manipulate the link to use the one with /Sites in the path and use the existing pattern for CORS trick
@g3rv4
Copy link
Owner

g3rv4 commented Jul 23, 2020

do you have a site where I can reproduce this?

@andrew-tc
Copy link
Contributor Author

andrew-tc commented Jul 24, 2020

Apparently chat rooms hosted on "The Stack Exchange Network", listed on https://chat.stackexchange.com/?tab=site&sort=active&host=*

Testing can be done on Charcoal HQ since it's a quite active chat room with a bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants