Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis ticks color #65

Open
jjagielka opened this issue Sep 27, 2019 · 2 comments
Open

Axis ticks color #65

jjagielka opened this issue Sep 27, 2019 · 2 comments

Comments

@jjagielka
Copy link

jjagielka commented Sep 27, 2019

There's a common D3 axis trick to set the ticks hight to a negative value to obtain a grid.
We can use that trick here as well, but the lines are drawn with stroke "#000" resulting in strong black lines.

A quick improvement would be to change the stroke value to "currentColor".

Ref: https://css-tricks.com/currentcolor/

@ffigiel
Copy link
Contributor

ffigiel commented Feb 21, 2021

It's possible to override the color with css

    .chart_axisGrid .tick > line {
      stroke: $grey-lighter;
    }

@gampleman
Copy link
Owner

I guess the idea here is that currentColor might be a better default, since the charts would adapt automatically to the colour of surrounding typography. However, this would be a breaking change (as the output of axes is to be depended upon), so I am unsure about this. I'll punt on it until we are ready to make the next major release (which to be clear, is not going to be in the short term).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants