Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the language selector to a drop-down box #61

Closed
ovari opened this issue Apr 2, 2022 · 12 comments · Fixed by #119
Closed

Convert the language selector to a drop-down box #61

ovari opened this issue Apr 2, 2022 · 12 comments · Fixed by #119
Labels
enhancement New feature or request

Comments

@ovari
Copy link
Contributor

ovari commented Apr 2, 2022

From this:

image

to this:

image

What do you think?

Thank you

@milotype
Copy link
Contributor

milotype commented Apr 2, 2022

I agree with @ovari.

Make a language drop-down list of (translated) languages, but place it into the website's menu as a separate item, for instance called "Languages". I'd suggest to define a percentage of translation, in order to define which languages are represented. IMO, translations should be at least 85 % translated in order to be considered.

That way the <nav class="col-12 d-flex justify-content-end language-navigation"> would be obsolete.

@danyeaw
Copy link
Member

danyeaw commented Apr 2, 2022

I would assume this is lower priority without more translations. I agree that a drop-down would be better in the future, but it doesn't really seem to be something we need immediately.

@danyeaw danyeaw added the enhancement New feature or request label Apr 2, 2022
@milotype
Copy link
Contributor

milotype commented Apr 2, 2022

I agree about the current low priority.

But that's why I've proposed Create 07-mulitingual.md #32 which would invite translators to translate the app and website, thus increasing the possibility of having more languages ...

And I still would suggest to implement my feature request Automatically Select Locale for Users #62, as well as placing a "Language" item into the website's menu for selecting languages.

I'm really sorry, but I'm not a programmer, so I can't help implementing it.

@ovari
Copy link
Contributor Author

ovari commented Apr 9, 2022

IMO, translations should be at least 85 % translated in order to be considered.

Please show all translations even if they are below 85%.

Some reasons to provide translations at all percentages are:

  • Some people may only translate the main page
  • It provides positive feedback as translators can see their translations, which then encourages them to do more
  • Other people can see translations and also provide translation

Thank you

@danyeaw
Copy link
Member

danyeaw commented Apr 11, 2023

Here are a few sites also using Jekyll that have dropdowns:

I'm kind of digging the translation logo as the dropdown button, what do others think?

@ovari
Copy link
Contributor Author

ovari commented Apr 11, 2023

https://f-droid.org/ - gray dropdown selector

@danyeaw
Copy link
Member

danyeaw commented Apr 12, 2023

Thanks for the input @ovari!

@amolenaar Since you created the original site style, do you have any input?

@milotype
Copy link
Contributor

Suggestion:
if you make a dropdown box for the languages, I'd suggest to add a separate menu item at the bottom of the list with a link to https://hosted.weblate.org/engage/gaphor/, for inviting users to translate. The text could be "Help translating", or something like that. This is something I found at https://joinpeertube.org/ and I find it's a slick solution.
language-menu

As an alternative I'd suggest to at least add a paragraph about translating in Gaphor's Contribute webpage https://gaphor.org/contribute.

For intance: Help translating Gaphor at Hosted Weblate.

In order to do that, a new string Help translating Gaphor at [Hosted Weblate](https://hosted.weblate.org/engage/gaphor/). would have to be added to the translation file https://hosted.weblate.org/projects/gaphor/gaphor-github-io/.

@ovari
Copy link
Contributor Author

ovari commented Apr 23, 2023

magyar should be written with a lowercase m.

@danyeaw can you please change Magyar to magyar?

Thank you

@danyeaw
Copy link
Member

danyeaw commented Apr 23, 2023

Hi @ovari, done!

@ovari
Copy link
Contributor Author

ovari commented Apr 23, 2023

@danyeaw can the list be sorted by language code?

Does #126 need to be deleted?

Thank you

@ovari
Copy link
Contributor Author

ovari commented Apr 23, 2023

@danyeaw can you please merge #129 instead of #126 ?

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants