Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRSciColl suggestion - Should reviewer comment be mandatory? #632

Open
ManonGros opened this issue Oct 9, 2024 · 2 comments
Open

GRSciColl suggestion - Should reviewer comment be mandatory? #632

ManonGros opened this issue Oct 9, 2024 · 2 comments
Labels
GRSciColl Issues related to institutions, collections and staff

Comments

@ManonGros
Copy link
Contributor

This was asked by one of our contractors because it was a bit odd to comment on a suggestion from IH.
I suppose the comments don't have to be mandatory. What do you think?

Note that this is low priority

@ManonGros ManonGros added the GRSciColl Issues related to institutions, collections and staff label Oct 9, 2024
@ahakanzn
Copy link
Contributor

ahakanzn commented Oct 9, 2024

If comments are mandatory for other suggestions I think we shouldn't change it for suggestions created by ih-sync. Are we talking about all suggestions? In that case we can change that.

@spalp
Copy link

spalp commented Oct 25, 2024

And would it be too much trouble to separate the current field 'comment, affiliation and additional update suggestion' into:

  • 'Name and affiliation' - obligatory (useful to assess credibility and to have a name when contacting them with further inquires about the suggested change)
  • 'Comment and additional update suggestion' - it is fine by me not to be obligatory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GRSciColl Issues related to institutions, collections and staff
Projects
None yet
Development

No branches or pull requests

3 participants